1479765 - Fennec media notification from old webpage shows up even though tab was closed

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Audio/Video, defect, P2)

Description

[Valentin Gosu [:valentin]]

The notification that appears when there is media playing in a tab shows up even though that tab was closed a long time ago:
https://photos.app.goo.gl/PNrNPDNGzRqYE1tx8
Screenshots show the notification, and current open tabs.

Contents of about:support
https://pastebin.mozilla.org/9090819

Comment 1

[Jan Henning [:JanH]]

I wonder whether this is a pre-existing issue, or somehow made worse by bug 1384866?

Comment 2

[Vlad Baicu]

I've been testing this area for quite some time and have been unable to reproduce this issue with the latest patches, is this issue still occurring Valentin ?

Ioana, have you guys encountered this situation during tests ? More info on this would be very appreciated.

Comment 3

[Valentin Gosu [:valentin]]

I haven't seen it in the last two weeks. It might be fixed already.

Comment 4

[Ioana Chiorean]

We did not encounter it but will inform the team to keep an eye on it.

Comment 5

[Bogdan Surd, QA [:bsurd, NI]]

Closing this based on Comment 3.

@Valentin thank you for your report if you notice this again please feel free to reopen the issue and we will do a thorough investigation. Haven't seen this occur on any of the devices I've tested, nor did anyone else from the team signal anything about this particular issue.

Comment 7

[Jan Henning [:JanH]]

Apparently still happens.

Comment 8

[Vlad Baicu]

I asked the QA team to verify with the STRs given in bug 1494264

Comment 9

[Bogdan Surd, QA [:bsurd, NI]]

Devices:
 - Samsung Galaxy Note 8 (Android 8);
 - OnePlus Two (Android 6.0.1);
 - Huawei P10 (Android 8.0).

Tried to reproduce this in the latest versions of Nightly, Beta and Release on a variety of sites (news.google, kotaku, youtube, vice, vimeo).

Following the steps in bug 1494264 didn't turn up any results either.

The media notification didn't remain displayed for any of the sites as soon as I closed the tab.

@firstdonowong could you provide the page you were on? Also, some details about your device and android version might be helpful. Thanks!

Comment 10

[firstdonowong]

I was visiting https://www.news.com.au/technology/online/social/australia-summed-up-in-one-facebook-post/news-story/1 c2f67aa32215ab7dff2ee4c0eb6b82d and clicked "see more" on the embedded Facebook post when it happened yesterday, was able to replicate yesterday. Using Android One on Nokia 6 Plus. Tried again today (same device, haven't updated anything) and unable to replicate bug. Sorry for trouble and please feel free to close bug

Comment 11

[Jan Henning [:JanH]]

(In reply to firstdonowong from comment #10)
> Sorry for trouble and please feel free to close bug

Not to worry. Unfortunately this issue is hard to reproduce, but your report shows that despite the recent code changes for the media notification we still have some issues that need investigating.

Comment 12

[Bogdan Surd, QA [:bsurd, NI]]

Tried to reproduce this on a Nokia 6 (7.1.1) sadly as Jan mentioned this seems to be quite hard to reproduce. Everything worked as expected. Will keep an eye out for this issue and will post any new relevant information that I find.

Comment 13

[Andrei Bodea[:andrei]]

Hello,

I was able to reproduce this issue but only one time on the latest Nightly Build 64.0a1(28-Sep-2018) with a Samsung Galaxy S8+ Android 8.0.0.

Note that I did the following steps in order to reproduce this issue:
 1. Launch Fennec and access https://www.bloomberg.com/europe
 2. Scroll down and wait for any video from the web page to load
 3. After the video loaded, open 5 more tabs
 4. Let the device idle until the screen turn off(with the 2 or 5 minutes option for screen timeout)
 5. Unlock the device and close all tabs from Nightly
 6. The Fennec media notification is still displayed even after the tab was closed

For more details please see the video https://goo.gl/ug7cM9

Thanks,
Andrei

Comment 14

[Vlad Baicu]

Thank you for the info and effort Andrei, but unfortunately I haven't been able to reproduce this on my devices and also nothing in the code seems off.

Since this issue seems to be related with the screen timeout, I'm thinking maybe a speculative fix with a wakelock when the media is playing. @Jan, what do you think about this option ?

Comment 15

[Jan Henning [:JanH]]

If I'm not mistaken, we're already requesting wakelocks (screen wakelocks for (foreground?) video playback and a plain CPU wakelock for audio playback), and anything over and above that sounds like a rather horrible hack, assuming it helps at all in the first place.
So I don't think we should do anything in that direction.

If anything, we should go through the relevant source code and add/extend the logging so we have a better chance of piecing together what happened from the logcat in case we manage to reproduce this again.

Comment 16

[firstdonowong]

The bug is reoccurring. I opened a page using tab queue https://www.sbs.com.au/news/emotional-support-squirrel-sees-woman-removed-from-plane then before I loaded that page opened another tab using tab queue https://www.beautiful.ai/?utm_s ource=pocket&utm_medium=email I then opened the 2nd tab, which playeda video. I closed the tab and the fennec notification described the first page (although I had not watched that video). I wasn't able to clear Fennec until force stopping Firefox.

Comment 17

[Vlad Baicu]

I have extended the logs and sent over a build to the QA team, they have also managed to reproduce it ocasionally. Hopefully, if they encounter it, we will also have some logs to look at. Thanks Jan ! I will come back with more info on this as soon as I have any

Comment 19

[Jan Henning [:JanH]]

The reporter from bug 1502001 claims to have found some pages where this consistently reproduces (see bug 1502001 comment 1 ), maybe this could help in tracking this down?

Comment 20

[IdmFoundInHim]

Just so we're clear, I created bug 1502001 because it appeared to me that this bug was about *all* media-equipped pages, an issue that had already been resolved.  Are we going to use this bug (1479765) to address the same issue as 1502001 (that is, about specific webpages)? If so, I will VERIFY DUPLICATE my bug.  If not, I will REOPEN it.

Comment 21

[IdmFoundInHim]

For now, I will put my comments here.
I have observed a few patterns. The notification shows up when the video player has loaded. 

These are my first test subjects:
https://www.cbssports.com/college-football/news/ap-top-25-poll-notre-dame-enters-top-five-florida-makes-a-huge-leap-in-college-football-rankings/
https://www.cbssports.com/college-football/news/battle-tested-buckeyes-next-hurdle-the-return-of-ohio-state-coach-urban-meyer/amp/
The first does not exhibit this bug, but the second does. So, the differences between the pages are:
1. The first page is a non-AMP page, while the second is an AMP page.  Other pages on this site (cbssports.com) appear to follow this rule: AMP pages have the bug while non-AMP equivalents (w/o the '/amp/' at the end of the URL). I have tested https://www.cbssports.com/college-football/news/battle-tested-buckeyes-next-hurdle-the-return-of-ohio-state-coach-urban-meyer/ and it does not have the bug, so this appears to be a reliable data point. However...
2. The non-AMP pages actually begin playing the video automatically (against my autoplay preferences, but that is a separate issue). Any time the video is actually played, it seems this bug does not occur.
This led me to check out some of the source code. The video player is an iframe in both.  There are differences between the two iframes. The AMP page iframe is surrounded in an <amp-iframe> tag, which operates under certain sandbox settings. (See https://www.ampproject.org/docs/reference/components/amp-iframe.) Any of this may be significant or completely useless.
3. Actually playing the video seems to fix the problem even if it is paused or playing when the tab is closed.

Comment 22

[Jan Henning [:JanH]]

(In reply to IdmFoundInHim from comment #20)
> Just so we're clear, I created bug 1502001 because it appeared to me that
> this bug was about *all* media-equipped pages, an issue that had already
> been resolved.  Are we going to use this bug (1479765) to address the same
> issue as 1502001 (that is, about specific webpages)? If so, I will VERIFY
> DUPLICATE my bug.  If not, I will REOPEN it.

I can't say that for sure, but even before your report we knew that there still are issues, it's just that they're hard to reproduce. So the hope is that everything observed has a common cause and your steps to reproduce might help in tracking this down. Hence I marked it as a duplicate to keep the investigations in one place for now.

Comment 23

[Jan Henning [:JanH]]

(In reply to Vlad Baicu from comment #17)
> I have extended the logs and sent over a build to the QA team, they have
> also managed to reproduce it ocasionally. Hopefully, if they encounter it,
> we will also have some logs to look at. Thanks Jan ! I will come back with
> more info on this as soon as I have any

Could you post a link with a Try push containing the extended logging?

Comment 25

[Vlad Baicu]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=68be2645d3d89990a0efc3fea2f8b0599b800a9f

Comment 26

[Vlad Baicu]

Looks like this is still unactionable. Please NI me if something comes up

Comment 28

[Liz Henry (:lizzard)]

Andreas suggests trying cnn.com to reproduce.

Comment 30

[Andrei Bodea[:andrei]]

I was able to reproduce this issue on the latest Nightly build 66.0a1 with Google Pixel 3XL Android P.

Note that I did the following steps in order to reproduce this issue:

1. Launch fennec.
2. Access https://edition.cnn.com/videos
3. Access https://edition.cnn.com
4. Open a new clean tab

Notes: After opening both cnn web pages wait ~like 1-2 minutes until any video from the web pages starts.
Sometimes I was able to reproduce the issue only after opening a third web page / tab but most of the time I was able to reproduce it only with the 2 cnn web pages
Also, note that in order to reproduce this issue every time you have to wait those 1-2 minutes after opening the web pages, otherwise the issue cannot be reproduced all the time
For more details please see the video.

Comment 31

[Liz Henry (:lizzard)]

May be related to bug 1516665.

Comment 32

[Vlad Baicu]

Andrei, we now have additional logging in place on Nightly from bug 1516665 - see patch 3. Could you please try to reproduce again and attach the logcat ? Also, I think it would be helpful to know the exact time when the notification appears so that we may compare with what the logs are showing us.

Comment 33

[Andrei Bodea[:andrei]]

Vlad, I was able to reproduce it and I have attached a logcat.
The notification appears once I access https://edition.cnn.com/videos, once a video from that website starts, the notification is displayed.
The logcat that I attached is not so big, but for sure you will find the information between 17:30-17:35 in the log.
If I can help you with any other information regarding this issue please do not hesitate to ask.

Comment 34

[Rafal Ryba]

The bug is still there and it is very annoying. I need to kill Firefox in order for a video notification to close.

Comment 35

[knipesteven]

I think I've found a reliable way to reproduce this bug.

Open a webpage that contains a video, then switch to a different app while the page is loading. Wait a few seconds, then return to the firefox app.
Now closing the tab or navigating to another page won't remove the notification. Going to another page with video normally will remove the old notification, and then leaving that page removes the new one and thus leaves you without any notifications.

I'm certain I've encountered the bug in other situations, but hopefully this will help figure out what's going wrong.

Comment 38

[funni.clonk]

Same issue here. How could such a buggy function be released at all? Is there at least one way to turn off the notification in about:config?

Comment 39

[Peter Hamberg]

Same issue. Firefox android 68.5.2 on Lineage OS 15.1 Android 8.1 on a Nexus 6p. Annoyingly stochastic bug.

Comment 40

[Peter Hamberg]

68.5.0, not 2

Comment 41

[josepmesteves]

Same issue on Firefox 68.8.1 on Samsung S9

Comment 42

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.