1479809 - App menu: Settings hangs for up to 30 sec before showing

Status: RESOLVED FIXED

(Firefox for iOS :: General, enhancement, P1)

Description

[:garvan]

This should only require one tap.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Is this still happening for you? I cannot reproduce on my iPad running iOS 11.4.

Comment 2

[:garvan]

I can't repro in simulator, I does happen periodically on my iPad running 11.4.
I'll try for a better STR

Comment 3

[:garvan]

Clarifying the original report.
On iPad, and signed in to sync:
1) press app menu, and wait 7-9sec
2) tap settings in the app menu which is still open from step 1
3) takes anywhere from 5-30 seconds to show the settings screen

Both Justin and myself reproduced using these steps. Estimated 1/5 tries it happens.

This is clearly not main thread blockage, as the UI thread is interactive (confirmed by tapping on settings a second time, and the highlight gets removed).

Comment 4

[:garvan]

Additional Note: signed in to sync is not required

Comment 5

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/0514eae524d1a693a8cdfbdb73840ea36c2ec123

Comment 6

[:garvan]

For posterity adding another interesting note: tapping anywhere on the screen while in the stuck state, will un-stick the app, and the settings will show immediately. This confirms the hypothesis (and the bug fix) that the event loop is stuck - in this case due to dismissing the popover and showing a modal at the same time.