1479832 - treeherder preserves "fromchange" across repos

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P1)

Description

[Aki Sasaki (not active)]

The "fromchange" filter allows us to scroll back a number of pushes, which is helpful. Treeherder also allows us to have 3 repos worth of tabs, which allow us to switch between 3 recent repos.

However, when used together, things break.

STR:

Go to https://treeherder.mozilla.org/?repo=mozilla-inbound
click on the '20' at the bottom to go back 20 pushes
click over to 'try'

Expected: try shows its pushes, either from the tip or 20 back

Actual: "Error retrieving push data!" because fromchange is set to 4ab2e8e356be, or some other revision that isn't in Try.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3906

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/76656421fbc87c907ca632b7ca4a6bf09052c853
Bug 1479832 - Fix repo urls having inappropriate params (#3906)