Closed
Bug 1479860
Opened 6 years ago
Closed 6 years ago
aCompileEventHandlers is unused.
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
Details
Attachments
(2 files)
I was annoyed at the boolean arguments from BindToTree / UnbindFromTree. What's better than seeing some of them can go away.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → emilio
Assignee | ||
Comment 1•6 years ago
|
||
All callers pass true. MozReview-Commit-ID: 8hsSOxghLck
Assignee | ||
Comment 2•6 years ago
|
||
Mostly automatic via sed. Only parts which I touched manually (apart from a couple ones where I fixed indentation or which had mispelled arguments) are the callers. I may have removed a couple redundant `virtual` keywords as well when I started to do it manually, I can revert those if wanted. Most of them are just removing the argument, but in Element.cpp I also added an assertion for GetBindingParent when binding the ShadowRoot's kids (the binding parent is set from the ShadowRoot constructor, and I don't think we bind a shadow tree during unlink or what not which could cause a behavior difference).
Comment 3•6 years ago
|
||
Comment on attachment 8996400 [details] Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision. https://phabricator.services.mozilla.com/D2573
Attachment #8996400 -
Flags: review+
Comment 4•6 years ago
|
||
Comment on attachment 8996404 [details] Remove unused aCompileEventHandlers argument from BindToTree. r=bz Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision. https://phabricator.services.mozilla.com/D2574
Attachment #8996404 -
Flags: review+
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/990d4d5b66ad Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz https://hg.mozilla.org/integration/mozilla-inbound/rev/2442b01a0d06 Remove unused aCompileEventHandlers argument from BindToTree. r=bz
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/mozilla-inbound/rev/f96fb13a7389 Add a missing override keyword that got lost. r=me
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/990d4d5b66ad https://hg.mozilla.org/mozilla-central/rev/2442b01a0d06 https://hg.mozilla.org/mozilla-central/rev/f96fb13a7389
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•