Closed Bug 1479860 Opened Last year Closed Last year

aCompileEventHandlers is unused.

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

Details

Attachments

(2 files)

I was annoyed at the boolean arguments from BindToTree / UnbindFromTree. What's better than seeing some of them can go away.
Assignee: nobody → emilio
All callers pass true.

MozReview-Commit-ID: 8hsSOxghLck
Mostly automatic via sed. Only parts which I touched manually (apart from a
couple ones where I fixed indentation or which had mispelled arguments) are the
callers. I may have removed a couple redundant `virtual` keywords as well when
I started to do it manually, I can revert those if wanted.

Most of them are just removing the argument, but in Element.cpp I also added an
assertion for GetBindingParent when binding the ShadowRoot's kids (the binding
parent is set from the ShadowRoot constructor, and I don't think we bind a
shadow tree during unlink or what not which could cause a behavior difference).
Comment on attachment 8996400 [details]
Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2573
Attachment #8996400 - Flags: review+
Comment on attachment 8996404 [details]
Remove unused aCompileEventHandlers argument from BindToTree. r=bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2574
Attachment #8996404 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/990d4d5b66ad
Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/2442b01a0d06
Remove unused aCompileEventHandlers argument from BindToTree. r=bz
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f96fb13a7389
Add a missing override keyword that got lost. r=me
You need to log in before you can comment on or make changes to this bug.