1479860 - aCompileEventHandlers is unused.

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

I was annoyed at the boolean arguments from BindToTree / UnbindFromTree. What's better than seeing some of them can go away.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz

All callers pass true.

MozReview-Commit-ID: 8hsSOxghLck

Comment 2

[Emilio Cobos Álvarez [:emilio]]

Attachment: Remove unused aCompileEventHandlers argument from BindToTree. r=bz

Mostly automatic via sed. Only parts which I touched manually (apart from a
couple ones where I fixed indentation or which had mispelled arguments) are the
callers. I may have removed a couple redundant `virtual` keywords as well when
I started to do it manually, I can revert those if wanted.

Most of them are just removing the argument, but in Element.cpp I also added an
assertion for GetBindingParent when binding the ShadowRoot's kids (the binding
parent is set from the ShadowRoot constructor, and I don't think we bind a
shadow tree during unlink or what not which could cause a behavior difference).

Comment 3

[Phabricator Automation]

Comment on attachment 8996400 [details]
Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2573

Comment 4

[Phabricator Automation]

Comment on attachment 8996404 [details]
Remove unused aCompileEventHandlers argument from BindToTree. r=bz

Boris Zbarsky [:bz] (no decent commit message means r-) has approved the revision.

https://phabricator.services.mozilla.com/D2574

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/990d4d5b66ad
Remove aCompileEventHandlers argument in nsXULElement::AddListenerFor. r=bz
https://hg.mozilla.org/integration/mozilla-inbound/rev/2442b01a0d06
Remove unused aCompileEventHandlers argument from BindToTree. r=bz

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f96fb13a7389
Add a missing override keyword that got lost. r=me

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/990d4d5b66ad
https://hg.mozilla.org/mozilla-central/rev/2442b01a0d06
https://hg.mozilla.org/mozilla-central/rev/f96fb13a7389