Closed Bug 1479868 Opened 2 years ago Closed 2 years ago

Add tests for virtual function resolution and field calls

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Just adding some tests.
Comment on attachment 8996410 [details] [diff] [review]
Add tests for virtual function resolution and field calls

Review of attachment 8996410 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for adding more tests.  This looks fine although I didn't review it too thoroughly.  One question though, when do these tests get run?
Attachment #8996410 - Flags: review?(jcoppeard) → review+
(In reply to Jon Coppeard (:jonco) from comment #2)
> Comment on attachment 8996410 [details] [diff] [review]
> Add tests for virtual function resolution and field calls
> 
> Review of attachment 8996410 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Thanks for adding more tests.  This looks fine although I didn't review it
> too thoroughly.  One question though, when do these tests get run?

Good point. I only run these tests manually. They're the main way I work on this stuff now, since I don't have to wait for the whole tree to build (twice, if I don't reuse the opt shell that gets built to run things.) I have sixgill tests in the sixgill tree that are run when sixgill gets built (it's a toolchain job on taskcluster), but I guess I never hooked up these tests. I'll take a stab at doing that to see how hard it is.

Finding stuff at the right place in the automation environment is always fun. But if I have the hazard jobs run them, it shouldn't be too bad.
Priority: -- → P3
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6173c4ae224
Add tests for virtual function resolution and field calls, r=jonco
https://hg.mozilla.org/mozilla-central/rev/f6173c4ae224
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.