Closed Bug 1479890 Opened 3 years ago Closed 3 years ago

Error setting tab.hidden attribute in sessionstore

Categories

(SeaMonkey :: Session Restore, enhancement)

SeaMonkey 2.57 Branch
enhancement
Not set
normal

Tracking

(seamonkey2.57esr fixed, seamonkey2.60 fixed)

RESOLVED FIXED
seamonkey2.60
Tracking Status
seamonkey2.57esr --- fixed
seamonkey2.60 --- fixed

People

(Reporter: frg, Assigned: frg)

Details

Attachments

(1 file)

Timestamp: 7/31/2018, 12:38:52 PM
Error: TypeError: setting getter-only property "hidden"
Source File: jar:file:///C:/Program%20Files/SeaMonkey/omni.ja!/components/nsSessionStore.js
Line: 2497
I though first about just using
> tab.setAttribute("hidden", tabData.hidden);

but I think this is the better approach.
Attachment #8996460 - Flags: review?(iann_bugzilla)
Attachment #8996460 - Flags: approval-comm-esr60?
Comment on attachment 8996460 [details] [diff] [review]
1479890-tabhidden.patch

LGTM r/a=me
Attachment #8996460 - Flags: review?(iann_bugzilla)
Attachment #8996460 - Flags: review+
Attachment #8996460 - Flags: approval-comm-esr60?
Attachment #8996460 - Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/00325311f1a5
Fix invalid assignment to readonly tab.hidden. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.