Closed
Bug 1479890
Opened 7 years ago
Closed 7 years ago
Error setting tab.hidden attribute in sessionstore
Categories
(SeaMonkey :: Session Restore, enhancement)
SeaMonkey
Session Restore
Tracking
(seamonkey2.53 fixed, seamonkey2.57esr fixed)
RESOLVED
FIXED
seamonkey2.60
People
(Reporter: frg, Assigned: frg)
Details
Attachments
(1 file)
|
1.29 KB,
patch
|
iannbugzilla
:
review+
iannbugzilla
:
approval-comm-esr60+
|
Details | Diff | Splinter Review |
Timestamp: 7/31/2018, 12:38:52 PM
Error: TypeError: setting getter-only property "hidden"
Source File: jar:file:///C:/Program%20Files/SeaMonkey/omni.ja!/components/nsSessionStore.js
Line: 2497
|
Assignee | |
Comment 1•7 years ago
|
||
I though first about just using
> tab.setAttribute("hidden", tabData.hidden);
but I think this is the better approach.
Attachment #8996460 -
Flags: review?(iann_bugzilla)
Attachment #8996460 -
Flags: approval-comm-esr60?
Comment on attachment 8996460 [details] [diff] [review]
1479890-tabhidden.patch
LGTM r/a=me
Attachment #8996460 -
Flags: review?(iann_bugzilla)
Attachment #8996460 -
Flags: review+
Attachment #8996460 -
Flags: approval-comm-esr60?
Attachment #8996460 -
Flags: approval-comm-esr60+
Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/00325311f1a5
Fix invalid assignment to readonly tab.hidden. r=IanN
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 4•7 years ago
|
||
status-seamonkey2.60:
--- → fixed
Target Milestone: --- → seamonkey2.60
|
|
Assignee | |
Updated•3 years ago
|
status-seamonkey2.53:
--- → fixed
status-seamonkey2.60:
fixed → ---
Version: SeaMonkey 2.57 Branch → Trunk
You need to log in
before you can comment on or make changes to this bug.
Description
•