1479945 - Remove legacy gunk from chrome.manifest parser

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Kris Maglione [:kmag]]

We still have a bunch of gunk in the manifest parser for extension types and directives that are no longer supported. That can all go away now.

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1479945: Part 1 - Remove nominal support for binary-component directive.

Review commit: https://reviewboard.mozilla.org/r/260566/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260566/

Comment 2

[Kris Maglione [:kmag]]

Attachment: Bug 1479945: Part 2 - Remove support for componentonly directive flag.

This serves no purpose now that legacy theme support has been removed.

Review commit: https://reviewboard.mozilla.org/r/260568/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260568/

Comment 3

[Kris Maglione [:kmag]]

Attachment: Bug 1479945: Part 3 - Remove support for apponly directive flag.

This is unused now that binary component support has been removed.

Review commit: https://reviewboard.mozilla.org/r/260570/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260570/

Comment 4

[Kris Maglione [:kmag]]

Attachment: Bug 1479945: Part 4 - Remove unused isContract directive flag.

Review commit: https://reviewboard.mozilla.org/r/260572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260572/

Comment 5

[Kris Maglione [:kmag]]

Attachment: Bug 1479945: Part 5 - Remove the 'allowbootstrap' directive flag.

For all intents and purposes, this is now the same as the 'ischrome' flag.

Review commit: https://reviewboard.mozilla.org/r/260574/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260574/

Comment 6

[Nathan Froyd [:froydnj]]

Comment on attachment 8996489 [details]
Bug 1479945: Part 1 - Remove nominal support for binary-component directive.

https://reviewboard.mozilla.org/r/260566/#review267664

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8996490 [details]
Bug 1479945: Part 2 - Remove support for componentonly directive flag.

https://reviewboard.mozilla.org/r/260568/#review267666

Comment 8

[Nathan Froyd [:froydnj]]

Comment on attachment 8996491 [details]
Bug 1479945: Part 3 - Remove support for apponly directive flag.

https://reviewboard.mozilla.org/r/260570/#review267668

r=me if you talk to the thunderbird people and determine that they don't need this stuff anymore, because I'm pretty sure `MOZ_BINARY_EXTENSION` is meant for them.  And if they don't need it, please file a followup bug about removing `MOZ_BINARY_EXTENSIONS` from `old-configure.in`.  Thanks!

Comment 9

[Nathan Froyd [:froydnj]]

Comment on attachment 8996492 [details]
Bug 1479945: Part 4 - Remove unused isContract directive flag.

https://reviewboard.mozilla.org/r/260572/#review267670

::: xpcom/components/ManifestParser.cpp
(Diff revision 1)
>      int aLineNo, char* const* aArgv);
>    void (nsChromeRegistry::*regfunc)(
>      nsChromeRegistry::ManifestProcessingContext& aCx,
>      int aLineNo, char* const* aArgv, int aFlags);
> -
> -  bool isContract;

I guess everybody must silently initialize this to `false`...?

Comment 10

[Nathan Froyd [:froydnj]]

Comment on attachment 8996493 [details]
Bug 1479945: Part 5 - Remove the 'allowbootstrap' directive flag.

https://reviewboard.mozilla.org/r/260574/#review267672

Comment 11

[Kris Maglione [:kmag]]

(In reply to Nathan Froyd [:froydnj] from comment #8)
> Comment on attachment 8996491 [details]
> Bug 1479945: Part 3 - Remove support for apponly directive flag.
> 
> https://reviewboard.mozilla.org/r/260570/#review267668
> 
> r=me if you talk to the thunderbird people and determine that they don't
> need this stuff anymore, because I'm pretty sure `MOZ_BINARY_EXTENSION` is
> meant for them.  And if they don't need it, please file a followup bug about
> removing `MOZ_BINARY_EXTENSIONS` from `old-configure.in`.  Thanks!

It doesn't actually do anything anymore. It only applies to the binary-component entry type, which we ripped out support for several years ago.

So I guess it should just be removed from old-configure.in.

Comment 12

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/71700b368132dd0735d4b792d6dbc6e1365790d4
Bug 1479945: Part 1 - Remove nominal support for binary-component directive. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/ca43bd11f43161f03d3e0dd6bd9b28d446bbe7e1
Bug 1479945: Part 2 - Remove support for componentonly directive flag. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/20a1a11b4d0ba7010b36b952bb212f3c36e6aac3
Bug 1479945: Part 3 - Remove the unused 'apponly' directive flag. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/163276881d35942172fd18d8f2cd270fbab1de71
Bug 1479945: Part 4 - Remove unused isContract directive flag. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/2a5aa9de1fd9760a9245ecae815a6e02bb9eef42
Bug 1479945: Part 5 - Remove the 'allowbootstrap' directive flag. r=froydnj

Comment 13

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/71700b368132
https://hg.mozilla.org/mozilla-central/rev/ca43bd11f431
https://hg.mozilla.org/mozilla-central/rev/20a1a11b4d0b
https://hg.mozilla.org/mozilla-central/rev/163276881d35
https://hg.mozilla.org/mozilla-central/rev/2a5aa9de1fd9

Comment 14

[Cosmin Sabou [:CosminS]]

Backed out for causing a big performance regression on OS X and as request by igoldan. 

https://hg.mozilla.org/mozilla-central/rev/fe6020e5c9d901a40fa2e7ea2f1ab2a36bf6d856

Comment 15

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd4c3fa90356094539c4db6e57e5305a54972ad3
Bug 1479945: Part 1 - Remove nominal support for binary-component directive. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/3821fc94ce7860c68a9dcf5d92c47313c6879649
Bug 1479945: Part 2 - Remove support for componentonly directive flag. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/018b21c272eef2eb6d4b13a5543cb7a8738b9334
Bug 1479945: Part 3 - Remove the unused 'apponly' directive flag. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/aacb32def2732583f705e84acd718f68537425a7
Bug 1479945: Part 4 - Remove unused isContract directive flag. r=froydnj

https://hg.mozilla.org/integration/mozilla-inbound/rev/2c99b0a2731affc443ffce02df78690da7cb5af2
Bug 1479945: Part 5 - Remove the 'allowbootstrap' directive flag. r=froydnj

Comment 16

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/bd4c3fa90356
https://hg.mozilla.org/mozilla-central/rev/3821fc94ce78
https://hg.mozilla.org/mozilla-central/rev/018b21c272ee
https://hg.mozilla.org/mozilla-central/rev/aacb32def273
https://hg.mozilla.org/mozilla-central/rev/2c99b0a2731a