JSNatives have no callers in the hazard analysis callgraph

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P3
normal
RESOLVED FIXED
10 months ago
7 months ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

(Blocks 1 bug)

unspecified
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 months ago
It doesn't actually matter for the hazard analysis itself, since RunScript and friends can already GC and having the JSNative in the graph doesn't help.

But it's kind of useful for other callgraph uses.
Comment on attachment 8996508 [details] [diff] [review]
Synthesize call edges from Interpret and EnterJit to all JSNatives

Review of attachment 8996508 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, makes sense.

::: js/src/devtools/rootAnalysis/computeCallgraph.js
@@ +289,5 @@
> +        JSNatives.push(functionName);
> +}
> +
> +function postprocess_callgraph() {
> +    for (const caller of Object.keys(JSNativeCaller)) {

Could use a comment to say what this is doing.
Attachment #8996508 - Flags: review?(jcoppeard) → review+
(Assignee)

Updated

7 months ago
Priority: -- → P3

Comment 3

7 months ago
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c22b643cdf51
Synthesize call edges from Interpret and EnterJit to all JSNatives, r=jonco

Comment 5

7 months ago
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/113e7326a16a
Synthesize call edges from Interpret and EnterJit to all JSNatives, r=jonco

Comment 6

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/113e7326a16a
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.