Closed Bug 1479961 Opened 2 years ago Closed 2 years ago

JSNatives have no callers in the hazard analysis callgraph

Categories

(Core :: JavaScript: GC, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox65 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

It doesn't actually matter for the hazard analysis itself, since RunScript and friends can already GC and having the JSNative in the graph doesn't help.

But it's kind of useful for other callgraph uses.
Comment on attachment 8996508 [details] [diff] [review]
Synthesize call edges from Interpret and EnterJit to all JSNatives

Review of attachment 8996508 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, makes sense.

::: js/src/devtools/rootAnalysis/computeCallgraph.js
@@ +289,5 @@
> +        JSNatives.push(functionName);
> +}
> +
> +function postprocess_callgraph() {
> +    for (const caller of Object.keys(JSNativeCaller)) {

Could use a comment to say what this is doing.
Attachment #8996508 - Flags: review?(jcoppeard) → review+
Priority: -- → P3
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c22b643cdf51
Synthesize call edges from Interpret and EnterJit to all JSNatives, r=jonco
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/113e7326a16a
Synthesize call edges from Interpret and EnterJit to all JSNatives, r=jonco
https://hg.mozilla.org/mozilla-central/rev/113e7326a16a
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla65
You need to log in before you can comment on or make changes to this bug.