Closed Bug 1479962 Opened Last year Closed Last year

Switch to using attributes instead of coded annotations for AutoGCRooter & friends

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: sfink, Assigned: sfink)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

RootedWhatever's rootedness is not inherited by subclasses or containing structures, so I can't use the same mechanism for AutoGCRooter. But I dislike hardcoded non-attribute exceptions in the JS analysis code.
Attachment #8996509 - Flags: review?(jcoppeard) → review+
Pushed by sfink@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b595406855e
Add JS_HAZ_ROOTED_BASE for AutoGCRooter, which assumes all descendants are rooted, r=jonco
https://hg.mozilla.org/mozilla-central/rev/5b595406855e
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.