1480018 - Use BaseObjectElementIndex/BaseObjectSlotIndex when accessing elements/slots instead of Base(Value)Index

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

We have the BaseObjectElementIndex and BaseObjectSlotIndex helpers to explicitly document access to object elements and object slots, but in some cases we're instead directly using BaseIndex/BaseValueIndex.

Comment 1

[André Bargull [:anba]]

Attachment: bug1480018.patch

Replaces BaseIndex/BaseValueIndex with BaseObjectElementIndex/BaseObjectSlotIndex  where possible.

Drive-by changes:
- Change some BaseIndex constructor callers to directly call the constructor instead of using |BaseIndex index = BaseIndex(...)|.
- Delete the unused Address and BaseIndex default constructors.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Comment on attachment 8996626 [details] [diff] [review]
bug1480018.patch

Review of attachment 8996626 [details] [diff] [review]:
-----------------------------------------------------------------

Looks like a good set of cleanup :)

::: js/src/jit/BaselineCompiler.cpp
@@ -2727,5 @@
>  {
>      EnvironmentCoordinate ec(pc);
>      Shape* shape = EnvironmentCoordinateToEnvironmentShape(script, pc);
>  
> -    Address addr;

/me is gently surprised there isn't a compiler error about this.

Comment 3

[André Bargull [:anba]]

Attachment: bug1480018.patch

Updated to apply cleanly on inbound, carrying r+.

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dafa3f50d04bf9bc793cab64e8caf4653b907dc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ef2291b03c19
Change some Base(Value)Index users to BaseObject(Element|Slot)Index. r=mgaudet

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/ef2291b03c19