1480020 - Make jit::Relocation an enum class

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Comment 1

[André Bargull [:anba]]

Attachment: bug1480020.patch

Looks like an enum class, is used like an enum class, so it's probably an enum class.

Comment 2

[Ted Campbell [:tcampbell]]

Comment on attachment 8996637 [details] [diff] [review]
bug1480020.patch

Review of attachment 8996637 [details] [diff] [review]:
-----------------------------------------------------------------

Converting to an enum class is a good idea, but I think the final type should be renamed to RelocationKind.

r=me if you s/Relocation/RelocationKind/. There are not a lot of uses to change.

Comment 3

[André Bargull [:anba]]

(In reply to Ted Campbell [:tcampbell] from comment #2)
> Converting to an enum class is a good idea, but I think the final type
> should be renamed to RelocationKind.
> 
> r=me if you s/Relocation/RelocationKind/. There are not a lot of uses to
> change.

With RelocationKind as the type name, do you prefer if the RelocationKind member of RelativePatch sticks with its current name ("kind") [1], too? (In the patch the field name was changed to "relocation" to match the type name.)

[1] https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/js/src/jit/x86-shared/Assembler-x86-shared.h#258

Comment 4

[Ted Campbell [:tcampbell]]

(In reply to André Bargull [:anba] from comment #3)
> With RelocationKind as the type name, do you prefer if the RelocationKind
> member of RelativePatch sticks with its current name ("kind") [1], too? (In
> the patch the field name was changed to "relocation" to match the type name.)

Yes, revert this back to 'kind' please :)

Comment 5

[André Bargull [:anba]]

Attachment: bug1480020.patch

Updated per review comments, carrying r+.

Comment 6

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dafa3f50d04bf9bc793cab64e8caf4653b907dc

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/994e5a4714a2
Change js::jit::Relocation into an enum class. r=tcampbell

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/994e5a4714a2