1480038 - Update the "Continue" button in the new cert error pages to "Continue…"

Status: RESOLVED FIXED

(Firefox :: Security, enhancement)

Comment 1

[Trisha Gupta [:trisha]]

Attachment: bug1480038.patch

Comment 2

[Francesco Lodolo [:flod]]

Comment on attachment 8996655 [details] [diff] [review]
bug1480038.patch

Review of attachment 8996655 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/locales/en-US/chrome/overrides/netError.dtd
@@ +10,4 @@
>  <!ENTITY returnToPreviousPage.label "Go Back">
>  <!ENTITY returnToPreviousPage1.label "Go Back (Recommended)">
>  <!ENTITY advanced.label "Advanced">
> +<!ENTITY continue.label "Continue…">

Sorry, this needs a new ID, since I assume we care for all localizations to update their translation accordingly.
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 3

[Trisha Gupta [:trisha]]

Attachment: bug1480038.patch

Thanks, that's what I suspected. Made the changes now.

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8996662 [details] [diff] [review]
bug1480038.patch

Review of attachment 8996662 [details] [diff] [review]:
-----------------------------------------------------------------

Is there a reason not to fix this one as well, and remove the old string completely?
https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/browser/base/content/aboutNetError-new.xhtml#179

Comment 5

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #4)
> Is there a reason not to fix this one as well, and remove the old string
> completely?
> https://searchfox.org/mozilla-central/rev/
> 196560b95f191b48ff7cba7c2ba9237bba6b5b6a/browser/base/content/aboutNetError-
> new.xhtml#179

Sorry, ignore this, brain clearly doesn't work well in warm weather, given that's the file you're already changing in this patch.

Having said that: if the old string (continue.label) is not used anymore, it should be removed from netError.dtd
https://searchfox.org/mozilla-central/search?q=continue.label&path=

Comment 6

[Trisha Gupta [:trisha]]

Attachment: bug1480038.patch

Comment 7

[Dorel Luca [:dluca]]

Hello,

I am getting this error when trying to apply your patch in order for it to be landed.

applying bug1480038.patch
patch failed, unable to continue (try -v)
patch failed, rejects left in working directory
errors during apply, please fix and qrefresh bug1480038.patch

Can you please take a look?

Comment 8

[Francesco Lodolo [:flod]]

I get this error when trying to import the patch

> abort: bad hunk #1: incomplete hunk

My gut instinct suggests that you edited the .patch file directly, instead of generating a new one from the tree?

Comment 9

[Trisha Gupta [:trisha]]

Attachment: Bug 1480038 - Update the Continue button in new cert-error pages

Review commit: https://reviewboard.mozilla.org/r/261150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261150/

Comment 10

[Trisha Gupta [:trisha]]

Carrying r+ over from the previous patch. I have re-based it on Central and re-submitted it through MozReview to avoid confusion. Hope this works!

Comment 11

[Francesco Lodolo [:flod]]

Comment on attachment 8997342 [details]
Bug 1480038 - Update the Continue button in new cert-error pages

https://reviewboard.mozilla.org/r/261150/#review268192

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9243cab39914
Update the Continue button in new cert-error pages r=flod

Comment 13

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/9243cab39914

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a692112bf9b8
Update the 'Continue...' label in new cert-error pages. r=johannh