Closed Bug 1480055 Opened Last year Closed Last year

Sort out around nsIEditor::ShouldTxnSetSelection()

Categories

(Core :: DOM: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(4 files)

No description provided.
Comment on attachment 8996935 [details]
Bug 1480055 - part 1: Remove nsIEditor::shouldTxnSetSelection()

https://reviewboard.mozilla.org/r/260924/#review268160
Attachment #8996935 - Flags: review?(m_kato) → review+
Comment on attachment 8996936 [details]
Bug 1480055 - part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection()

https://reviewboard.mozilla.org/r/260926/#review268164
Attachment #8996936 - Flags: review?(m_kato) → review+
Comment on attachment 8996937 [details]
Bug 1480055 - part 3: Create non-virtual method to set EditorBase::mAllowsTransactionsToChangeSelection

https://reviewboard.mozilla.org/r/260928/#review268178
Attachment #8996937 - Flags: review?(m_kato) → review+
Comment on attachment 8996938 [details]
Bug 1480055 - part 4: Make AutoTransactionsConserveSelection take reference of Editor rather than pointer

https://reviewboard.mozilla.org/r/260930/#review268198
Attachment #8996938 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/6b0f8b1b33c0
part 1: Remove nsIEditor::shouldTxnSetSelection() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/a3ee99eced65
part 2: Rename EditorBase::GetShouldTxnSetSelection() to EditorBase::AllowsTransactionsToChangeSelection() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/702671b11b7c
part 3: Create non-virtual method to set EditorBase::mAllowsTransactionsToChangeSelection r=m_kato
https://hg.mozilla.org/integration/autoland/rev/e0fa16503d34
part 4: Make AutoTransactionsConserveSelection take reference of Editor rather than pointer r=m_kato
You need to log in before you can comment on or make changes to this bug.