Closed Bug 1480059 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12253 - Don't re-attach ::first-letter during style recalc.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12253 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12253
Details from upstream follow.

Rune Lillesveen <futhark@chromium.org> wrote:
>  Don't re-attach ::first-letter during style recalc.
>  
>  Update (create or destroy) the FirstLetterPseudoElement and its style
>  at the point where the block level element's layout sub-tree is up-to-
>  date. This means we will always attach the layout tree for the
>  ::first-letter element in Element::AttachLayoutTree, but the pseudo
>  element and its style may be created/updated at style recalc time,
>  layout tree rebuild time, or layout tree attachment time depending on
>  when we know what will be the LayoutText from which we will format the
>  first letter if any.
>  
>  UpdateFirstLetterPseudoElement is split out from UpdatePseudoElement to
>  make the code easier to read as the former case has some exceptional
>  cases.
>  
>  We no longer use the pseudo style cache for ::first-letter as we will
>  now compute the style only once per pass with the correct inheritance
>  parent.
>  
>  Bug: 847218
>  Change-Id: I7a1e2a60122891fa38998ff85e566bec0a38b513
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1155591
>  WPT-Export-Revision: 6cbbd052941276e659b5aedaa162a904984f014e
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fb7b1227df5b
[wpt PR 12253] - Don't re-attach ::first-letter during style recalc., a=testonly
https://hg.mozilla.org/mozilla-central/rev/fb7b1227df5b
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.