1480072 - Library button is displayed outside of it's "natural" position when resizing the browser window during a bookmark animation

Status: RESOLVED WONTFIX

(Firefox :: Theme, defect)

Description

[Emil Ghitta, QA [:emilghitta]]

Attachment: Library.gif

[Affected versions]:
63.0a1 (BuildId:20180731220208)
62.0b13 (BuildId:20180730180407)
61.0.1 (BuildId:20180704003137)
60.1.0esr (BuildId:20180621121604)

[Affected platforms]:
Windows 10 64bit.
macOS 10.13.4
Ubuntu 16.04 64bit.

[Steps to reproduce]:
1. Launch Firefox with a clean profile.
2. Access the following webpage: https://en.wikipedia.org/wiki/United_States
3. Bookmark the page.
4. Click the "Done" button from the "New Bookmark" panel or click outside the panel.
5. Resize the Browser Window as soon as the library icon's animation starts.

[Expected result]:
No visual issues are encountered.

[Actual result]:
The Library button is displayed out of it's "natural" position.

[Regression range]:
This seems to be a regression:

Last good revision: 0df56be60d07b4da1b7a387b3d69aac133df928a
First bad revision: b5a5c38a0add40203d29bfe9551ce160d67e0b61

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0df56be60d07b4da1b7a387b3d69aac133df928a&tochange=b5a5c38a0add40203d29bfe9551ce160d67e0b61


[Note]
For further information regarding this issue please observe the attached screencast.

Comment 1

[Emil Ghitta, QA [:emilghitta]]

Hi Jared, 

It seems that mozregression pointed out Bug 1384953 for causing this regression.

Can you please have a look into this?

Thanks!

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Bug 1403550 covered most of this situation, but the exception in your case is that the button is moving to the overflow panel during resize at which point we no longer update the position of the button.

This seems to be a small enough corner case that it wouldn't be worth the work to fix this and maintain another special case.