1480083 - Screen doesn't auto-rotate back to portrait after a fullscreen video is stopped - Android O devices

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Oana Horvath [:ohorvath]]

Devices: 
Samsung S7 Edge & S8 Note (Android 8.0)
OnePlus 5T (Android 8.0)
Build: Nightly 63 (2018-07-31)

Steps to reproduce:
1. Go to youtube, play a video in fullscreen.
2. Open the task manager and tap the app to return.
* On Nightly, close the PIP and tap the app from the task manager.

Expected result:
When you return to the browser it should rotate to portrait mode.

Actual result:
When the app goes to background, youtube stops the video, but when you return to the browser it's still in landscape mode.

Note:
Can't reproduce on other OS's, like:
Google Pixel (Android P Beta)
Nokia 6 (Android 7.1.1)
OnePlus 2(Android 6.0.1)

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 1480083 - After exiting PIP the restarted activity should have device's orientation; r=sdaswani

Comment 2

[:sdaswani]

Comment on attachment 9006246 [details]
Bug 1480083 - After exiting PIP the restarted activity should have device's orientation; r=sdaswani

:sdaswani only needinfo has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2676a02339f4
After exiting PIP the restarted activity should have device's orientation; r=sdaswani

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2676a02339f4

Comment 5

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 64 (2018-09-07).
Devices:
Devices: 
Samsung S7 Edge & S8 Note (Android 8.0)
OnePlus 5T (Android 8.0)

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 7

[Petru-Mugurel Lingurar [:petru]]

Comment on attachment 9006246 [details]
Bug 1480083 - After exiting PIP the restarted activity should have device's orientation; r=sdaswani

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1349523
[User impact if declined]: Visual bug - After restarting the app, the screen would be in landscape, irregular of device's actual orientation.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: --
[List of other uplifts needed for the feature/fix]: --
[Is the change risky?]: No
[Why is the change risky/not risky?]: Small change - added code changes orientation to match actual device's orientation when restarting the app.
[String changes made/needed]: --

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9006246 [details]
Bug 1480083 - After exiting PIP the restarted activity should have device's orientation; r=sdaswani

Uplift approved for 63 beta 5.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/093d1a92ce08

Comment 10

[Andrei Bodea[:andrei]]

Verified as fixed on latest Beta build - 63.0b5.
Device: Google Pixel C(Android 8.0.0). Following the steps from the description.