1480098 - After turning TalkBack off, the PIP mode doesn't work

Status: RESOLVED INVALID

(Firefox for Android Graveyard :: General, defect)

Description

[Oana Horvath [:ohorvath]]

Devices:
Samsung Galaxy Note 8 (Android 8.0)
OnePlus 5T (Android 8.0)

Not reproducing on Google Pixel (Android P Beta).

Build: Nightly 63 (2018-07-31)

Steps to reproduce:
1. Activate & deactivate the A11y screen reader.
2. Go to youtube and play a video in fullscreen mode.
3. Tap the home button to launch the PIP mode.

Expected result:
Based on https://bugzilla.mozilla.org/show_bug.cgi?id=1349523#c7 PIP doesn't work with the screen reader. But after turning off the screen reader, it would be expected to work again.

Actual result:
PIP doesn't work anymore after turning on&off the screen reader.

Comment 1

[Oana Horvath [:ohorvath]]

Sorry, corrections:
Reproducing on Samsung devices:
Samsung Galaxy S8 (Android 8.0)
Samsung S7 Edge (Android 8.0)

*NOT* reproducing on 
OnePlus 5T (Android 8.0)
Google Pixel (Android P Beta)

Comment 2

[Petru-Mugurel Lingurar [:petru]]

Confirmed this reproducing on a Samsung Galaxy S8 with Android 8.0.

But as in https://bugzilla.mozilla.org/show_bug.cgi?id=1349523#c7 ,
even after disabling the accessibility service, when trying enterPictureInPictureMode() [1] I see in logs
> Device doesn't support picture-in-picture mode 

Also tried with Google Maps and saw that PIP mode doesn't work anymore also.
Also tried with VLC and saw that it immediately crashes.
Fennec is also crashing the second time PIP mode is tried, issue to be addressed in Bug 1488691

The only solution for making PIP mode available again seems to be a device restart.

[1] https://developer.android.com/reference/android/app/Activity.html#enterPictureInPictureMode(android.app.PictureInPictureParams)

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Oana, please test again to confirm the same behavior (inability to enter PIP mode again) for other apps which suggest a Samsung framework issue and not a problem with our app.

Comment 4

[Petru-Mugurel Lingurar [:petru]]

Small update, definitely looks like a framework issue:

> ActivityManager: Activity Manager Crash. UID:10252 PID:15369 TRANS:259
>   java.lang.IllegalStateException: enterPictureInPictureMode: Device doesn't support picture-in-picture mode.
>   at 
> com.android.server.am.ActivityManagerService.ensureValidPictureInPictureActivityParamsLocked(ActivityManagerService.java:10539)
>        at com.android.server.am.ActivityManagerService.enterPictureInPictureMode(ActivityManagerService.java:10412)
>        at android.app.IActivityManager$Stub.onTransact(IActivityManager.java:3826)
>        at com.android.server.am.ActivityManagerService.onTransact(ActivityManagerService.java:3843)
>        at android.os.Binder.execTransact(Binder.java:682)

Comment 5

[Oana Horvath [:ohorvath]]

(In reply to Petru-Mugurel Lingurar[:petru] from comment #3)
> Oana, please test again to confirm the same behavior (inability to enter PIP
> mode again) for other apps which suggest a Samsung framework issue and not a
> problem with our app.

You are right Petru, the Samsung's PIP mode doesn't work either after turning on&off the Talkback assistant. I'll close this bug and thank you for your investigation.