Closed
Bug 1480105
Opened 7 years ago
Closed 7 years ago
Use "WebDriver:AcceptAlert" instead of "WebDriver:AcceptDialog" in Marionette
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: whimboo, Assigned: u602518, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=py])
User Story
To get started with Marionette tests please read the following documentation: https://firefox-source-docs.mozilla.org/testing/marionette/marionette/NewContributors.html
Attachments
(1 file)
The following code in Marionette needs to be updated to make use of the new `WebDriver:AcceptAlert` end-point:
https://searchfox.org/mozilla-central/rev/196560b95f191b48ff7cba7c2ba9237bba6b5b6a/testing/marionette/client/marionette_driver/marionette.py#546
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
Reporter | |
Comment 3•7 years ago
|
||
Vinícius, thank you a lot for this patch! I triggered a try build to verify that it all works. Once it has been completed I will review your patch.
Assignee: nobody → viniciuscosta0197
Status: NEW → ASSIGNED
|
|
Reporter | |
Comment 4•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8996860 [details]
Bug 1480105 - Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette.
https://reviewboard.mozilla.org/r/260874/#review267972
Looks good!
Attachment #8996860 -
Flags: review?(hskupin) → review+
Pushed by hskupin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/da105ff7490c
Using WebDriver:AcceptAlert instead of WebDriver:AcceptDialog in Marionette. r=whimboo
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Henrik, that's great! I'm looking to get involved with the Auto-Tools teams, so I will be looking into other good bugs to get a better grasp of the code base and workflow.
|
|
Reporter | |
Comment 8•7 years ago
|
||
Wonderful. Please don't miss to join us on IRC. You can find me as whimboo in the #ateam channel. Best if you get in contact with me and we can find something else for you. Thanks.
|
||
Updated•2 years ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•