1480115 - Edit and Resend: Cannot remove last character from request method textbox

Status: RESOLVED DUPLICATE of bug 1451494

(DevTools :: Netmonitor, defect, P3)

Description

[Nick]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0
Build ID: 20180704003137

Steps to reproduce:

I used "https://bandcamp.com/api/account/1/my_bands", but any URL works.

Version: 62.0b13, I could also repeat this in 61.0.1.

1. Open Developer Tools, navigate to the network tab
2. Select a request and hit the "Edit and Resend" button
3. Try to delete all characters, to change it to "POST" for example




Actual results:

"GET" is repopulated in the textbox after the last character is removed.


Expected results:

The textfield should be left blank, at least while focused, to allow other request methods to be entered.

Also a combo box would be awesome.

Comment 1

[Damira Akh]

Build ID 	20180704003137
User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:61.0) Gecko/20100101 Firefox/61.0

I was able to reproduce this bug. I can not remove the "GET" character.

Comment 2

[Nick]

I believe I found the source of the issue:

devtools/client/netmonitor/src/components/CustomRequestPanel.js:217

          input({
            className: "custom-method-value",
            id: "custom-method-value",
            onChange: (evt) =>
              this.updateCustomRequestFields(evt, request, updateRequest),
            value: method || "GET",
          }),

When you make `method` an empty string it is falsy and so returns "GET". Fixing this would require a bit more boldness than I anticipated for my first submission. There are also other event handlers for the other fields doing similar things.

Comment 3

[Peter Bašista]

When you select the entire "GET" text and replace it with a single "P", then you can finish typing "OST" and you will end up with "POST".

However, current Nightly 64.0a1 (2018-09-06) would still not allow me to "Edit and Resend" this particular request. Even when I do not change the method name, clicking on the "Send" button does not appear to be doing anything.

It is strange also because it works on many other requests that I have randomly tried. But for some reason, the GET request from the linked page "https://bandcamp.com/api/account/1/my_bands" seems to be "unrepeatable" by Firefox.

Comment 4

[Patrick Brosset <:pbro>]

I can reproduce this issue. Thank you for filing it.
Moving to the right bugzilla component for further investigation and a fix.
Thank you for your patience.

Comment 5

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Tom: This is very similar to the bug 1478361 you've fixed.
Do you think you could look at this one too?
Thanks!
Honza

Comment 6

[Tom Glowka]

Sure, I'll take it!
Assign it to me please.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Awesome, done!

Honza

Comment 8

[Tom Glowka]

Hey Honza,
I wanted to get on with this issue, but it looks like solved. After investigating it a little bit I think it was https://bugzilla.mozilla.org/show_bug.cgi?id=1451494, which looks like 100% duplicate, that solved it.
Shall I just resolve it as duplicate or are there any other steps that I should take?

Comment 9

[Peter Bašista]

Apart from the main issue being resolved, the "previously-unrepeatable" GET request from "https://bandcamp.com/api/account/1/my_bands" can be repeated correctly in the current Nightly 65.0a1 (2018-11-26) (64-bit).

Comment 10

[Jan Honza Odvarko [:Honza] (always need-info? me)]

@Tom @pbaista: thanks for the update! I agree, this report can be closed.

Honza