1480145 - Annotate jit-spew for vm-wrappers with function name and annotate String and RegExp stubs

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

Add some more annotations, so it's easier to find the generated assembly code when looking at the output of 'IONFLAGS=codegen'.

Comment 1

[André Bargull [:anba]]

Attachment: bug1480145.patch

- When trace-logging is enabled (the default in debug builds), we can use VMFunction::name() to annotate the VM function wrapper code.
- String and RegExp stubs weren't annotated at all, which makes it hard to find the generated assembly code. And because the stub code is relatively large, I've also added annotations in the various sub-functions called from the main stub function.

Comment 2

[Nicolas B. Pierron [:nbp]]

Comment on attachment 8996760 [details] [diff] [review]
bug1480145.patch

Review of attachment 8996760 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jit/Ion.cpp
@@ +301,5 @@
>              // Duplicate VMFunction definition. See VMFunction::hash.
>              continue;
>          }
> +#ifdef JS_TRACE_LOGGING
> +        JitSpew(JitSpew_Codegen, "# VM function wrapper (%s)", fun->name());

Change the guard around VMFunction::name to be defined(JS_JITSPEW) || defined(JS_TRACE_LOGGING), and add a comment above VMFunction::name that this symbol should not be present in release builds. (Bug 1417028)

Comment 3

[André Bargull [:anba]]

Attachment: bug1480145.patch

Updated per review comments, carrying r+.

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=5dafa3f50d04bf9bc793cab64e8caf4653b907dc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e73d0543679d
Annotate jit-spew with the VMFunction name when available and annotate String and RegExp stubs. r=nbp

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/e73d0543679d