1480184 - [sync] Pontoon cannot synchronize suite/profile/bookmarks.inc correctly

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P2)

Description

[Michal Stanke (Mozilla.cz) [:mstanke][:MikkCZ]]

Pontoon cannot synchronize last two strings from suite/profile/bookmarks.inc. I have noticed a build error on Elmo caused most likely by these two commits:
- https://hg.mozilla.org/l10n-central/cs/rev/3a85c91d48be
- https://hg.mozilla.org/l10n-central/cs/rev/de187d6d0c2c

Note: the second commit was probably without any localizer interaction. The string version in History tab is listed as imported.

Today I have first tried to fix the string and add the missing #define at their beginning, but I actually got two compile errors on Elmo (https://hg.mozilla.org/l10n-central/cs/rev/f97b4b26492a). So I have decided to fix the file manually in Mercurial (https://hg.mozilla.org/l10n-central/cs/rev/7c3fd5aebdae), hoping all will be good again, but Pontoon now reports the last two strings in that file as missing.

Comment 1

[Matjaz Horvat [:mathjazz]]

Thanks for the report, Michal!

It turns out Silme .inc parser doesn't support empty translations as they are defined in the bookmarks.inc file:
https://github.com/mathjazz/pontoon-test/blob/master/en-US/bookmarks1.inc#L77-L85

I've opened a PR in Pontoon's silme fork:
https://github.com/mathjazz/silme/pull/2

Once this lands, we'll update Pontoon with the new silme version.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1040

Comment 3

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/d7a8437eced9d6528d8f9c07ea5127a514fbbf22
Fix bug 1480184: Upgrade to silme 0.9.4 (#1040)

We upgraded silme to fix its .inc parser to properly support empty
translations.