Construct all nsDocShell objects within a BrowsingContext

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P2
normal
RESOLVED FIXED
10 months ago
2 months ago

People

(Reporter: Nika, Assigned: farre)

Tracking

(Blocks 2 bugs)

unspecified
mozilla64
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox64 fixed, firefox65 fixed)

Details

Attachments

(3 attachments, 1 obsolete attachment)

No description provided.
Reporter

Updated

10 months ago
Priority: -- → P2
Reporter

Comment 2

9 months ago
Transferring to Andreas
Assignee: nika → afarre
Assignee

Updated

8 months ago
Blocks: 1495659
Assignee

Comment 4

8 months ago
Since nsDocShell is no longer created when nsComponentManagerImpl is
on the stack we now expose leaks tracked in Bug 1495659.

Depends on D7400
Attachment #8998548 - Attachment is obsolete: true
Assignee

Updated

8 months ago
Blocks: 1496722
These are only showing up in some WPT tests, right? This change will apply to all LSan tests, and this is a very broad change.

You should instead use the very nice per-directory setup jgraham created for LSan suppressions in WPT tests. For instance:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/websockets/__dir__.ini
QA Contact: overholt
QA Contact: overholt
Assignee

Comment 6

8 months ago
Add the property lsan-max-stack-depth to enable configuring how many
stack frames we allow LSANLeaks to record.

Comment 7

7 months ago
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0702430e839
Check for allowed patterns deeper in LSAN stack. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/3f53bdf6763d
Suppress leaks with nsDocShell::Create on the stack. r=mccr8
Attachment #9013555 - Attachment description: Bug 1480198 - Suppress leaks with nsDocShell::Create on the stack → Bug 1480198 - Suppress leaks with nsDocShell::Create on the stack.

Comment 8

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a0702430e839
https://hg.mozilla.org/mozilla-central/rev/3f53bdf6763d
Status: NEW → RESOLVED
Last Resolved: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13495 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13495
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/440852639?utm_source=github_status&utm_medium=notification)
Assignee

Updated

7 months ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13495
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/H4xFONJPQvWBiXWzm48RAA)
Upstream PR merged

Comment 13

7 months ago
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7afa638dc547
[wpt PR 13495] - [Gecko Bug 1480198] Check for allowed patterns deeper in LSAN stack., a=testonly

Comment 14

7 months ago
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5ffc2c0617
[wpt PR 13495] - [Gecko Bug 1480198] Check for allowed patterns deeper in LSAN stack., a=testonly

Comment 15

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9d5ffc2c0617
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago7 months ago
Resolution: --- → FIXED
I believe :farre has not landed the actual core of this bug yet. Re-opening & ni? to confirm with :farre
Status: RESOLVED → REOPENED
Flags: needinfo?(afarre)
Resolution: FIXED → ---
Assignee

Comment 17

7 months ago
Yes, only preparatory patches landed.
Flags: needinfo?(afarre)
Assignee

Updated

7 months ago
Depends on: 1500869
Attachment #9013554 - Attachment description: Bug 1480198 - Construct nsDocShell objects inside BrowsingContext → Bug 1480198 - Construct nsDocShell objects inside BrowsingContext.

Comment 18

7 months ago
Pushed by afarre@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5da3c0dad67a
Construct nsDocShell objects inside BrowsingContext. r=peterv

Comment 19

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5da3c0dad67a
Status: REOPENED → RESOLVED
Last Resolved: 7 months ago7 months ago
Resolution: --- → FIXED
Depends on: 1504989
Component: DOM → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.