1480198 - Construct all nsDocShell objects within a BrowsingContext

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1480198 - Construct nsDocShell objects inside BrowsingContext, r=peterv

Comment 2

[Nika Layzell [:nika] (ni? for response)]

Transferring to Andreas

Comment 3

[Andreas Farre [:farre]]

Attachment: Bug 1480198 - Construct nsDocShell objects inside BrowsingContext.

Comment 4

[Andreas Farre [:farre]]

Attachment: Bug 1480198 - Suppress leaks with nsDocShell::Create on the stack.

Since nsDocShell is no longer created when nsComponentManagerImpl is
on the stack we now expose leaks tracked in Bug 1495659.

Depends on D7400

Comment 5

[Andrew McCreight [:mccr8]]

These are only showing up in some WPT tests, right? This change will apply to all LSan tests, and this is a very broad change.

You should instead use the very nice per-directory setup jgraham created for LSan suppressions in WPT tests. For instance:
https://searchfox.org/mozilla-central/source/testing/web-platform/meta/websockets/__dir__.ini

Comment 6

[Andreas Farre [:farre]]

Attachment: Bug 1480198 - Check for allowed patterns deeper in LSAN stack.

Add the property lsan-max-stack-depth to enable configuring how many
stack frames we allow LSANLeaks to record.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0702430e839
Check for allowed patterns deeper in LSAN stack. r=jgraham
https://hg.mozilla.org/integration/autoland/rev/3f53bdf6763d
Suppress leaks with nsDocShell::Create on the stack. r=mccr8

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/a0702430e839
https://hg.mozilla.org/mozilla-central/rev/3f53bdf6763d

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/13495 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13495
* continuous-integration/travis-ci/pr (https://travis-ci.org/web-platform-tests/wpt/builds/440852639?utm_source=github_status&utm_medium=notification)

Comment 11

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/13495
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/H4xFONJPQvWBiXWzm48RAA)

Comment 12

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7afa638dc547
[wpt PR 13495] - [Gecko Bug 1480198] Check for allowed patterns deeper in LSAN stack., a=testonly

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9d5ffc2c0617
[wpt PR 13495] - [Gecko Bug 1480198] Check for allowed patterns deeper in LSAN stack., a=testonly

Comment 15

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/9d5ffc2c0617

Comment 16

[Nika Layzell [:nika] (ni? for response)]

I believe :farre has not landed the actual core of this bug yet. Re-opening & ni? to confirm with :farre

Comment 17

[Andreas Farre [:farre]]

Yes, only preparatory patches landed.

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5da3c0dad67a
Construct nsDocShell objects inside BrowsingContext. r=peterv

Comment 19

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5da3c0dad67a

Comment 20

[Chris Peterson [:cpeterson]]

Retroactively moving fixed bugs whose summaries mention "Fission" (or other Fission-related keywords) but are not assigned to a Fission Milestone to an appropriate Fission Milestone.

This will generate a lot of bugmail, so you can filter your bugmail for the following UUID and delete them en masse:

0ee3c76a-bc79-4eb2-8d12-05dc0b68e732