Closed Bug 1480222 Opened Last year Closed Last year

Preemptively fix unified bustage in layout/style

Categories

(Core :: CSS Parsing and Computation, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

Details

Attachments

(5 files)

Attached file build error output
Previously: bug 1437723, bug 1326574, bug 1321495

layout/style doesn't quite build successfully right now, when I disable unified
builds (by doing s/UNIFIED_SOURCES/SOURCES/ in its moz.build file)

Build errors attached (
Assignee: nobody → dholbert
Priority: -- → P3
* ArenaRefPtrInlines.h calls nsPresArena::RegisterArenaRefPtr()
  and hence needs nsPresArena.h.
* nsComputedDOMStyle.cpp calls nsCSSProps::PropHasFlags()
  and hence needs nsCSSProps.h.
With these 4 patches, I can build successfully with unification disabled in layout/style.
Summary: Preemptively fix most unified bustage in layout/style → Preemptively fix unified bustage in layout/style
Comment on attachment 8996861 [details]
Bug 1480222 part 1: Add include for ServoBindings.h to some .cpp files in layout/style, to fix various non-unified build errors about undeclared identifier 'Servo_XYZ'. r?TYLin

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

https://phabricator.services.mozilla.com/D2629
Attachment #8996861 - Flags: review+
Comment on attachment 8996863 [details]
Bug 1480222 part 2: Add include for RefCounted.h to some .cpp files in layout/style that use the mozilla::RefCounted type. r?TYLin

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

https://phabricator.services.mozilla.com/D2630
Attachment #8996863 - Flags: review+
Comment on attachment 8996864 [details]
Bug 1480222 part 3: Add includes to fix unified bustage in ArenaRefPtrInlines.h and nsComputedDOMStyle.cpp. r?TYLin

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

https://phabricator.services.mozilla.com/D2631
Attachment #8996864 - Flags: review+
Comment on attachment 8996870 [details]
Bug 1480222 part 4: Give css ErrorReporter.h an actual nsString.h include (not nsStringFwd), since it has actual nsString member-vars which need full definition. r?TYLin

Ting-Yu Lin [:TYLin] (UTC-7) has approved the revision.

https://phabricator.services.mozilla.com/D2632
Attachment #8996870 - Flags: review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/02bce0f59fb0
part 1: Add include for ServoBindings.h to some .cpp files in layout/style, to fix various non-unified build errors about undeclared identifier 'Servo_XYZ'. r=TYLin
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f141de2d941
part 2: Add include for RefCounted.h to some .cpp files in layout/style that use the mozilla::RefCounted type. r=TYLin
https://hg.mozilla.org/integration/mozilla-inbound/rev/833ded7c7005
part 3: Add includes to fix unified bustage in ArenaRefPtrInlines.h and nsComputedDOMStyle.cpp. r=TYLin
https://hg.mozilla.org/integration/mozilla-inbound/rev/085d8dd2394b
part 4: Give css ErrorReporter.h an actual nsString.h include (not nsStringFwd), since it has actual nsString member-vars which need full definition. r=TYLin
Flags: needinfo?(dholbert) → in-testsuite-
You need to log in before you can comment on or make changes to this bug.