1480233 - Define in AllocKinds.h which kinds support compacting

Status: RESOLVED DUPLICATE of bug 1479937

(Core :: JavaScript: GC, enhancement)

Description

[Ted Campbell [:tcampbell]]

Currently, we define the AllocKind that support compacting in [1]. It might be nicer to track this info in the AllocKinds.h table instead. This makes it clearer what types *do not* support compacting.

[1] https://searchfox.org/mozilla-central/rev/d0a0ae30d534dc55e712bd3eedc1b4553ba56323/js/src/gc/GC.cpp#2173-2200

Comment 1

[Ted Campbell [:tcampbell]]

Attachment: 0001-Bug-1480233-Define-compacting-GC-support-in-AllocKin.patch

Move the AllocKindsToRelocate table into AllocKind macro-table instead.

Comment 2

[Ted Campbell [:tcampbell]]

Comment on attachment 8996855 [details] [diff] [review]
0001-Bug-1480233-Define-compacting-GC-support-in-AllocKin.patch

Review of attachment 8996855 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/gc/GC.cpp
@@ +2482,5 @@
>      // Check that we did as much compaction as we should have. There
>      // should always be less than one arena's worth of free cells.
> +    for (auto kind : AllAllocKinds()) {
> +        if (!IsMovableKind(kind))
> +            continue;

Simplify this to
> for (auto kind : MovableAllocKinds()) {

Comment 3

[Steve Fink [:sfink] [:s:]]

What do you think of my attempt in bug 1479937? Too weird? Merge them?

Comment 4

[Ted Campbell [:tcampbell]]

Should have checked first..

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1765ed67a90a
Define compacting GC support in AllocKind.h. r=sfink

Comment 6

[Ted Campbell [:tcampbell]]

Attachment: 0001-Bug-1480233-Define-compacting-GC-support-in-AllocKin.patch

I dun goofed. Review of this patch was done on Bug 1479937. Stamping here for posterity.

https://bugzilla.mozilla.org/show_bug.cgi?id=1479937#c5

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/1765ed67a90a