1480245 - Clean up legacy methods on nsXPTInterfaceInfo

Status: RESOLVED FIXED

(Core :: XPConnect, enhancement, P3)

Description

[Nika Layzell [:nika] (ni? for response)]

nsXPTInterfaceInfo contains a series of methods which only have their current signature due to backwards-compatibility with nsIInterfaceInfo: https://searchfox.org/mozilla-central/rev/d0a0ae30d534dc55e712bd3eedc1b4553ba56323/xpcom/reflect/xptinfo/xptinfo.h#72,97-120

It would be nice to get rid of all of these callers. Most should be pretty straightforward to remove, as they have relatively few callers.

Comment 1

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1480245 - Remove compatibility methods from nsXPTInterfaceInfo. r?nika

Comment 2

[Adrian Wielgosik [:adrian17]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76fcf40200521ecdc56eb229ef7df99c7452e64e

I put a single review with 5 commits, let me know if you want separate review requests. (I don't know the phabricator workflow too well.)

Comment 3

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1480245, part 1 - Remove compatibility methods from nsXPTInterfaceInfo. r?nika

I left GetMethodInfo, GetConstant as they are still useful as separate methods.

Comment 4

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1480245, part 2 - Stop storing a copy of interface name in nsXPCWrappedJSClass. r?nika

Comment 5

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1480245, part 3 - Remove always-true nsXPTInterfaceInfo::EnsureResolved(). r?nika

Comment 6

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1480245, part 4 - Remove always-true nsXPTInterfaceInfo::IsScriptable(). r?nika

Comment 7

[Adrian Wielgosik [:adrian17]]

Attachment: Bug 1480245, part 5 - Clean up some uses of nsXPTInterfaceInfo::GetMethodInfo. r?nika

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c06ff6513da3
part 1 - Remove compatibility methods from nsXPTInterfaceInfo. r=nika

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cd5d392de531
part 2 - Stop storing a copy of interface name in nsXPCWrappedJSClass. r=nika

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d3ccc933550
part 3 - Remove always-true nsXPTInterfaceInfo::EnsureResolved(). r=nika

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0248f5aff651
part 4 - Remove always-true nsXPTInterfaceInfo::IsScriptable(). r=nika

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb7b0a61d22c
part 5 - Clean up some uses of nsXPTInterfaceInfo::GetMethodInfo. r=nika

Comment 13

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/c06ff6513da3
https://hg.mozilla.org/mozilla-central/rev/cd5d392de531
https://hg.mozilla.org/mozilla-central/rev/8d3ccc933550
https://hg.mozilla.org/mozilla-central/rev/0248f5aff651
https://hg.mozilla.org/mozilla-central/rev/bb7b0a61d22c