Clean up legacy methods on nsXPTInterfaceInfo

RESOLVED FIXED in Firefox 65

Status

()

enhancement
P3
normal
RESOLVED FIXED
Last year
9 months ago

People

(Reporter: Nika, Assigned: adrian17)

Tracking

unspecified
mozilla65
Points:
---

Firefox Tracking Flags

(firefox65 fixed)

Details

Attachments

(5 attachments, 1 obsolete attachment)

nsXPTInterfaceInfo contains a series of methods which only have their current signature due to backwards-compatibility with nsIInterfaceInfo: https://searchfox.org/mozilla-central/rev/d0a0ae30d534dc55e712bd3eedc1b4553ba56323/xpcom/reflect/xptinfo/xptinfo.h#72,97-120

It would be nice to get rid of all of these callers. Most should be pretty straightforward to remove, as they have relatively few callers.
Priority: -- → P3
Assignee: nobody → adrian.wielgosik
Status: NEW → ASSIGNED
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=76fcf40200521ecdc56eb229ef7df99c7452e64e

I put a single review with 5 commits, let me know if you want separate review requests. (I don't know the phabricator workflow too well.)
Attachment #9018408 - Attachment is obsolete: true
I left GetMethodInfo, GetConstant as they are still useful as separate methods.
Attachment #9019634 - Attachment is obsolete: true
Attachment #9019634 - Attachment is obsolete: false
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c06ff6513da3
part 1 - Remove compatibility methods from nsXPTInterfaceInfo. r=nika
Keywords: checkin-needed
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cd5d392de531
part 2 - Stop storing a copy of interface name in nsXPCWrappedJSClass. r=nika
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8d3ccc933550
part 3 - Remove always-true nsXPTInterfaceInfo::EnsureResolved(). r=nika
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0248f5aff651
part 4 - Remove always-true nsXPTInterfaceInfo::IsScriptable(). r=nika
Pushed by ebalazs@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bb7b0a61d22c
part 5 - Clean up some uses of nsXPTInterfaceInfo::GetMethodInfo. r=nika
You need to log in before you can comment on or make changes to this bug.