14803 - textarea not setting value properly

Status: VERIFIED DUPLICATE of bug 18859

(Core :: Layout: Form Controls, defect, P3)

Description

[rginda]

Load attached test case in apprunner
select initial text and delete it
enter 'a\nb\n' (where \n is [ENTER], not a literal '\' and 'n')
click [Clear Value]
* the value will be cleared
enter 'c\nd\n'
click [Clear Value]
* the value WILL NOT be cleared
click [Set Value to 'foo\nbar\n'
* 'foo\nbar\n' will be PRE-PENDED to the existing text, instead of replacing it
clear all text from the textarea
click [Dump Value]
* the value will still have a '\n' in it.

This problem does not show up if '\n' is not part of the value keyed in, eg:
entering 'a', [Clear Value], 'b', [Clear Value], 'c', [Clear Value] works as
expected.

Comment 1

[rginda]

Attachment: test cse for bug 14803

Comment 2

[Peter Trudelle]

this is an HTML form control, not an xptoolkit widget. reassigning.

Comment 3

[karnaze (gone)]

Reassigning to Steve.

Comment 4

[buster]

accepting, setting target milestone to M12

Comment 5

[Kathleen :Brade]

change qa contact to gerardok

Comment 6

[Kathleen :Brade]

I tracked this down to the following:
 in nsGfxTextControlFrame::SelectAllTextContent
there is this line:  nsCOMPtr<nsIDOMCharacterData>text =
do_QueryInterface(lastChild);

This line results in text being null in the case where the last character is /n
so the selection is not made and therefore not replaced when the new text is set/
inserted.

It seems to me that we should have/use SelectAll to avoid these edge cases across
the various usages of the editor.

Comment 7

[buster]

dup of 18859. kathy diagnosed the problem correctly, kin and joe found the same
solution for a similar problem that they already fixed.  I'll remove the dead
code.

*** This bug has been marked as a duplicate of 18859 ***

Comment 8

[Dan Erikson]

verifying as a dup.