1480331 - Decide what to do wrt exceptions in libjsoncpp

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

The toolkit/components/jsoncpp/src/lib_json/moz.build file contains the following comment:

# This code is only used in the stand-alone minidump analyzer executable so
# enabling exceptions should be fine.


This was true when it was written, but is not true anymore, as of bug 1341423, which now ends up linking jsoncpp to libxul.

Comment 1

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

I've just hit this when I started using it to construct JSON structures, Coverity complained that I used functions that throw! (Coverity CID 1507054 "Uncaught exception".)

I think we should just compile it without exceptions everywhere, for easier integration in Firefox. After a quick search, I didn't find any code that used JsonCpp and exceptions.
I'll push a patch for review soon.

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Attachment: Bug 1480331 - Compile and build JsonCpp without exception handling - r?glandium

JsonCpp is used in different places around Firefox, which is normally built
without exception handling, so we don't want JsonCpp to throw.
Because we don't want to modify the JsonCpp files themselves (to ease future
update from the source), and some of its headers are directly included around
Firefox, we need to define JSON_USE_EXCEPTION to be 0 everywhere, which can
be done through moz.configure.
JsonCpp replaces its exception-triggering code with C asserts and aborts.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea1db7e224d5
Compile and build JsonCpp without exception handling - r=glandium

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/ea1db7e224d5