1480370 - ./mach static-analysis check FILE fails

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Bastien Abadie (please use [e-mail])]

When running a simple ./mach static-analysis check FILE, it fais with the following output. The error is on line 1703 of python/mozbuild/mozbuild/mach_commands.py, where check should be checks

Error running mach:

    ['--log-no-times', 'static-analysis', 'check', 'dom/base/TimeoutManager.cpp']

The error occurred in the implementation of the invoked mach command.

This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

TypeError: _get_clang_tidy_command() got an unexpected keyword argument 'check'

  File "/app/tmp/sa-central/python/mozbuild/mozbuild/mach_commands.py", line 1703, in check
    check=checks, header_filter=header_filter, sources=source, jobs=jobs, fix=fix)

Comment 1

[Andi [:andi]]

Attachment: Bug 1480370 - pass checks to _get_clang_tidy_command.

Review commit: https://reviewboard.mozilla.org/r/260944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/260944/

Comment 2

[Bastien Abadie (please use [e-mail])]

Comment on attachment 8996969 [details]
Bug 1480370 - pass checks to _get_clang_tidy_command.

Tested on my local instance of static analysis bot, clang-tidy works again. Thanks !

Comment 3

[Bastien Abadie (please use [e-mail])]

Comment on attachment 8996969 [details]
Bug 1480370 - pass checks to _get_clang_tidy_command.

https://reviewboard.mozilla.org/r/260944/#review267988

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a2d65d03e46a
pass checks to _get_clang_tidy_command. r=babadie+588857

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a2d65d03e46a