Closed Bug 1480384 Opened 5 years ago Closed 5 years ago

Remove unused "theme" property for DevTools autocomplete popup

Categories

(DevTools :: Shared Components, enhancement, P3)

Product:
DevTools
Component:
Shared Components
Type:
enhancement

Tracking

(firefox63 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(1 file)

Bug 1480384 - Remove unused theme option for autocomplete-popup;r=nchevobbe
46 bytes, text/x-phabricator-request
nchevobbe
: review+
Details | Review 
The DevTools autocomplete supports a "theme" option which should either be light, dark or auto.

This sets the class "light-theme" or "dark-theme" on some autocomplete elements. However this class is never used anywhere:

https://searchfox.org/mozilla-central/search?q=.light-theme&case=false&regexp=false&path= 

https://searchfox.org/mozilla-central/search?q=.dark-theme&case=false&regexp=false&path=

We can just remove the feature, the autocomplete is always styled using theme variables (or some other weirdness that would need cleanup such as https://searchfox.org/mozilla-central/rev/d0a0ae30d534dc55e712bd3eedc1b4553ba56323/devtools/client/themes/common.css#164-170)
Comment on attachment 8997028 [details]
Bug 1480384 - Remove unused theme option for autocomplete-popup;r=nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.

https://phabricator.services.mozilla.com/D2666
Attachment #8997028 - Flags: review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9620225007fd
Remove unused theme option for autocomplete-popup;r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/9620225007fd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.