1480414 - [Wayland] Make sure it works with OGL Compositor

Status: RESOLVED FIXED

(Core :: Widget: Gtk, enhancement)

Description

[Martin Stránský [:stransky] (ni? me)]

Let's make sure the Wayland port works with:

- enabled WebRender
- enabled OGL Compositor
- enabled GPU process (that would be the most difficult part)

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Игорь Шашкин feedback:

hw info: https://www.notebookcheck.net/Review-Apple-MacBook-Pro-Retina-13-Late-2013-Notebook.105035.0.html
sw info: fedora 28, gnome 3.28, firefox from master (last commit - Bug 1476405: Part 6 - Register AudioIPC threads with the profiler. r=kinetik)

opengl
Window and menu is rendered partially if i setup 200% scaling in gnome. With 100% all work fine. Screenshots in attach.
webrender
Am i right, that webrender enabled by default in master? gfx.webrender.enabled = true, but in about:support i see that basic compositor is used. Info in attach. Maybe should i enable additional flags?

Comment 2

[Robert Mader [:rmader]]

On my machine, the flatpak firefox nightly reliably crashes on the following site when webrender is enabled (in a gnome wayland session): https://ncase.me/trust/

It works fine though with basic or ogl renderer.

I also opened an issue on github (https://github.com/servo/webrender/issues/2953)

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to robert.mader from comment #2)
> On my machine, the flatpak firefox nightly reliably crashes on the following
> site when webrender is enabled (in a gnome wayland session):
> https://ncase.me/trust/
> 
> It works fine though with basic or ogl renderer.
> 
> I also opened an issue on github
> (https://github.com/servo/webrender/issues/2953)

Robert, do you mind to open a new bug for it? I can look at it then there. I already replied at github bug I prefer to track it here as I think it's wayland/EGL related issue. Thanks.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] from comment #3)
> (In reply to robert.mader from comment #2)
> > On my machine, the flatpak firefox nightly reliably crashes on the following
> > site when webrender is enabled (in a gnome wayland session):
> > https://ncase.me/trust/
> > 
> > It works fine though with basic or ogl renderer.
> > 
> > I also opened an issue on github
> > (https://github.com/servo/webrender/issues/2953)
> 
> Robert, do you mind to open a new bug for it? I can look at it then there. I
> already replied at github bug I prefer to track it here as I think it's
> wayland/EGL related issue. Thanks.

Filed as Bug 1482350

Comment 5

[Martin Stránský [:stransky] (ni? me)]

OGL Compositor seems to be supported fine, I see no issued on my Intel / Mesa DRI Intel(R) HD Graphics 530 (Skylake GT2).

WebRender will be covered by Bug 1482350 (seems to be mostly working except the https://ncase.me/trust/ site). OOP is covered by Bug 1481405.

Closing this one now as we're going to track it at Bug 635134.