1480431 - Linux opt javascript benchmark failures

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Cosmin Sabou [:CosminS]]

There are these failures on central: https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-searchStr=bench&selectedJob=191599427

Failure log:https://treeherder.mozilla.org/logviewer.html#?job_id=191600347&repo=mozilla-central&lineNumber=501

Downloading https://queue.taskcluster.net/v1/task/SarjU-nwTX6gIy4_9b4kbg/artifacts/public/build/target.jsshell.zip to /home/cltbld/fetches/target.jsshell.zip.tmp
Downloading https://queue.taskcluster.net/v1/task/SarjU-nwTX6gIy4_9b4kbg/artifacts/public/build/target.jsshell.zip
https://queue.taskcluster.net/v1/task/SarjU-nwTX6gIy4_9b4kbg/artifacts/public/build/target.jsshell.zip resolved to 10083111 bytes with sha256 c86a7f43fd0b3fc1757f80e83f72564ddcc69fe6fe446afb9f45af92af6f1f4c in 1.028s
Renaming to /home/cltbld/fetches/target.jsshell.zip
Extracting /home/cltbld/fetches/target.jsshell.zip to /home/cltbld/fetches using ['unzip', '/home/cltbld/fetches/target.jsshell.zip']
Traceback (most recent call last):
  File "/home/cltbld/checkouts/gecko/taskcluster/scripts/misc/fetch-content", line 338, in <module>
    sys.exit(main())
  File "/home/cltbld/checkouts/gecko/taskcluster/scripts/misc/fetch-content", line 334, in main
    return args.func(args)
  File "/home/cltbld/checkouts/gecko/taskcluster/scripts/misc/fetch-content", line 298, in command_task_artifacts
    fetch_urls(downloads)
  File "/home/cltbld/checkouts/gecko/taskcluster/scripts/misc/fetch-content", line 249, in fetch_urls
    f.result()
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 405, in result
    return self.__get_result()
  File "/usr/lib/python3.5/concurrent/futures/_base.py", line 357, in __get_result
    raise self._exception
  File "/usr/lib/python3.5/concurrent/futures/thread.py", line 55, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/home/cltbld/checkouts/gecko/taskcluster/scripts/misc/fetch-content", line 235, in fetch_and_extract
    extract_archive(dest_path, dest_dir, typ)
  File "/home/cltbld/checkouts/gecko/taskcluster/scripts/misc/fetch-content", line 202, in extract_archive
    with ifh, subprocess.Popen(args, cwd=str(dest_dir), bufsize=0,
AttributeError: __exit__
Traceback (most recent call last):
  File "./run-task", line 755, in <module>
    sys.exit(main(sys.argv[1:]))
  File "./run-task", line 742, in main
    fetch_artifacts(fetches)
  File "./run-task", line 496, in fetch_artifacts
    subprocess.run(cmd, check=True, env=os.environ)
  File "/usr/lib/python3.5/subprocess.py", line 708, in run
    output=stdout, stderr=stderr)

This might be related to https://bugzilla.mozilla.org/show_bug.cgi?id=1479533

Comment 1

[Gregory Szorc [:gps]]

This is a silly bug. I'll write a patch.

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1480431 - Make ifh a file object; r?tomprince

Otherwise it can't be used as a context manager since it
doesn't have __enter__ or __exit__.

Comment 3

[Phabricator Automation]

Comment on attachment 8997087 [details]
Bug 1480431 - Make ifh a file object; r?tomprince

Tom Prince [:tomprince] (limited availability Jul 16-29) has approved the revision.

https://phabricator.services.mozilla.com/D2672

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c78bc9cc725
Make ifh a file object; r=tomprince

Comment 5

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/6c78bc9cc725