Closed
Bug 1480493
Opened 7 years ago
Closed 7 years ago
Simplify dead code paths related to JSOP_NEWINIT
Categories
(Core :: JavaScript Engine, enhancement)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: mgaudet, Assigned: mgaudet)
Details
Attachments
(1 file)
JSOP_NEWINIT appears to never be emitted anymore with anything but a JSProto_Object key these days. This causes some extra complexity on consumers of JSOP_NEWINIT, for example the LNullarySharedStub codegen needing to handle the dead JSProto_Array case.
|
Assignee | |
Comment 1•7 years ago
|
||
|
|
Assignee | |
Comment 2•7 years ago
|
||
Wrote the patch (I would totally accept r- if we want to keep this functionality around!)
|
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → mgaudet
|
||
Comment 3•7 years ago
|
||
Comment on attachment 8997099 [details]
Remove initializer kind from JSOP_NEWINIT
Tooru Fujisawa [:arai] (PTO until Aug 7) has approved the revision.
Attachment #8997099 -
Flags: review+
Pushed by mgaudet@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dacdc94c62ba
Remove initializer kind from JSOP_NEWINIT r=arai
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•