1480508 - Add Top Site Search Shortcuts automatically for new and existing users

Status: VERIFIED FIXED

(Firefox :: New Tab Page, enhancement, P1)

Description

[Kate Hudson :k88hudson]

We would like to automatically add a Top Site Search Shortcut to users' for existing users if they have an open (i.e. unpinned) tile available and the host name (google, amazon) is found in their top sites.

Note that we should store some kind of state in persistent storage when we do this so that we do not add a second time if it is removed/edited/replaced.

Comment 1

[Ed Lee :Mardak]

The logic for converting the available search engines to special @aliased search will need to be duplicated from bug 1480504. See https://phabricator.services.mozilla.com/D2681 where it does Services.search.getEngines() then checking _isDefault and a global Map of prefix name matching "Google" and "Amazon"

Comment 2

[Ed Lee :Mardak]

Later on, this might be cleaned up by having activity stream import ChromeUtils.import("resource://gre/modules/PlacesSearchAutocompleteProvider.jsm") to get the same Map ?

Comment 3

[Adam Hillier :ahillier]

(See bug 1480509 comment 3) We will only add the @google search shortcut if the user doesn't have Google as their default search engine.

Comment 4

[Maria Popova]

Update 8/6/18: 
Google/Amazon should be pinned in that order to the first open position in everyone's Top Sites (regardless of frecency).

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4289

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/725532f6f8e922944ab28c484f38a1c933770ab7
Fix Bug 1480508 - add topSiteSearchShortcuts for new and existing users (#4289)

Comment 7

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/972b3c48c6e9

Comment 8

[Marius Coman [:mcoman], Ecosystem QA]

I have verified this on Windows 10 x64, Arch Linux and Mac 10.13.3 with the latest version of "Firefox Nightly" and I can confirm that the "Top Search Shortcuts" replace the existing top site cards of the same type (if those cards are unpinned) for older profiles, and if for new profiles, the "Top Site Search Shortcuts" are added automatically.

Comment 9

[Ed Lee :Mardak]

https://hg.mozilla.org/releases/mozilla-beta/rev/9e752b54a20f425449e1f00bf3adefa903f8051a

Comment 10

[Ciprian Muresan [:cmuresan], Ecosystem QA]

I have verified that the search shortcuts override preexisting Top Sites of the same type and that they are automatically added for new profiles in the latest Beta (62.0b18 Build ID 20180816151750) on Windows 10, Mac 10.13 and Arch Linux x64.