Closed Bug 1480542 Opened 6 years ago Closed 4 years ago

Make tab overflow menu permanently visible behind browser.tabs.tabmanager.enabled preference

Categories

(Firefox :: Tabbed Browser, enhancement, P3)

Product:
Firefox
Component:
Tabbed Browser
Version:
63 Branch
Type:
enhancement

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 73
Tracking Flags:
Tracking Status
firefox63 --- wontfix
firefox73 --- fixed

People

(Reporter: amylee, Assigned: umaralam48, Mentored)

References

(Blocks 1 open bug,
URL
)

Details

Attachments

(1 file, 6 obsolete files)

Bug 1480542: Add browser.tabs.tabmanager.enabled preference
47 bytes, text/x-phabricator-request
Details | Review 
Hi, 

I've attached a spec for the Overflow Menu (now Tab Manager) that will be permanently visible - and not only when there is an overflow of tabs.
Blocks: 1406255
(In reply to Amy Lee [:amylee] UX from comment #0)
> Hi, 
> 
> I've attached a spec for the Overflow Menu (now Tab Manager) that will be
> permanently visible - and not only when there is an overflow of tabs.

The link says "Sign in to Mozilla" and I'm not sure what kind of login information mozilla.invisionapp.com expects from me. Can you please attach the spec here or otherwise make it available publicly?
Flags: needinfo?(amlee)
Priority: -- → P3
(In reply to Dão Gottwald [::dao] from comment #1)
> (In reply to Amy Lee [:amylee] UX from comment #0)
> > Hi, 
> > 
> > I've attached a spec for the Overflow Menu (now Tab Manager) that will be
> > permanently visible - and not only when there is an overflow of tabs.
> 
> The link says "Sign in to Mozilla" and I'm not sure what kind of login
> information mozilla.invisionapp.com expects from me. Can you please attach
> the spec here or otherwise make it available publicly?
URL: https://mozilla.invisionapp.com/d/mai... → https://mozilla.invisionapp.com/share...
Flags: needinfo?(amlee)
(In reply to Amy Lee [:amylee] UX from comment #2)
> (In reply to Dão Gottwald [::dao] from comment #1)
> > (In reply to Amy Lee [:amylee] UX from comment #0)
> > > Hi, 
> > > 
> > > I've attached a spec for the Overflow Menu (now Tab Manager) that will be
> > > permanently visible - and not only when there is an overflow of tabs.
> > 
> > The link says "Sign in to Mozilla" and I'm not sure what kind of login
> > information mozilla.invisionapp.com expects from me. Can you please attach
> > the spec here or otherwise make it available publicly?

Hi, 

The login is your mozilla email and LDAP credentials. I've updated it with a public link.
Blocks: 1480532
Depends on: 1466732
See Also: → 1488149
See Also: → 714281
No longer blocks: 1406255
See Also: → 1520364
See Also: 1520364 →

Regarding the pointer to my bug 1520364 (which was rightly marked as a duplicate), you might in particular want to see my suggestion for an integer value in about:config to determine whether the Tab manager a.k.a. overflow menu a.k.a “List all tabs” button should only be visible in cases of overflow (as it is now), never be visible at all, or visible if n or more tabs are present (for a positive n).

I believe that other aspects of the new proposal should be configurable in about:config too. Primarily, the change that the manager shows all tabs in all windows, not just the current one. Also, the threshold of 6 tabs after which the “Show more tabs” submenu appears. The choices in the proposal might be about right for many users, but a) users with smaller screens might need a different threshold, and b) those with a larger number of windows which they use for well-organised groups of many tabs might prefer to only see the tabs in the current window, as they might not have a problem finding the right window but would then prefer to see all the tabs in that window without having to open a submenu.

Hi Sam, Can I start working on this?

Flags: needinfo?(sfoster)

(In reply to Divyansh Sharma [:spiro] from comment #8)

Hi Sam, Can I start working on this?

:spiro, this bug is ear-marked for this year's Google Summer of Code. We need to let that process complete before I can assign it.

Flags: needinfo?(sfoster)

hey sam, I am interested in this project as gsoc 2019 participant.
please guide me'

Hello Sam, I'm also interested in Tab Manager menu in Firefox Project as Google Summer of Code student. I would love to start working on this issue.

I have responded via email to both comment 10 and comment 11 with suggestions on how to get started with a good-first-bug.

Mentor: sfoster

Hi Sam,
I am interested in this project as a GSoC 2019 applicant. Could you please guide me on this and help me get started?

Hi Sam, My name is Sahil Bhosale from India and I am interested in working on "Tab Manager menu in Firefox" project idea during GSOC 2019.

Flags: needinfo?(sfoster)

I have replied to both comment 13 and comment 14 via email with suggestions on how to get started with a good-first-bug.

Flags: needinfo?(sfoster)

Hello , My name is Aman Kumar Singla, I am currently studying in IIT Roorkee,India .I am interest in "Tab Manager menu in Firefox" project for gsoc2019. I need a little more info. to get started.

1.What are the steps to set up the project locally and link to documentation of source code.
2.What are the relavent IRC Channels to discuss more about the project?
3.Can you suggest me some good-first-issue so that i may start contributing

I would be highly thankful to you

Hi, my name is Ravi Maurya. I am interested in "Tab Manager menu in Firefox" project. Need some guidance how to start with it.

Hi Sam! I'm Umar and I'm interested to contribute to this feature. Please send your destined email this way too. :)

I've responded to comment 16, comment 17, and comment 18 via email. If you are interested in this project, please just email me directly - my address is on my bugzilla profile - we don't need to spam this bug further :)

See Also: bug 1525305

Hey my name is Jatin Varlyani, I am interested in working on "Tab Manager menu in Firefox" project idea in GSOC 2019.

(In reply to varlyanijatin88 from comment #21)

Hey my name is Jatin Varlyani, I am interested in working on "Tab Manager menu in Firefox" project idea in GSOC 2019.

Please contact me directly (see comment #19), my email is available on my bugzilla profile.

See Also: → 356980
Depends on: 1556500

Hi Sam, can you assign this bug to me?

Assignee: nobody → nguyenvandung02051999

(In reply to Peter Nguyen from comment #30)

Created attachment 9073575 [details]
Bug 1480542 : WIP - Implement new overflow menu to permanently be visible.

Depends on D35570

Peter, can you go through and abandon all but the revision you are actively working on?

Flags: needinfo?(nguyenvandung02051999)
Attachment #9073144 - Attachment is obsolete: true
Attachment #9073288 - Attachment is obsolete: true
Attachment #9073568 - Attachment is obsolete: true
Attachment #9073571 - Attachment is obsolete: true
Attachment #9073566 - Attachment is obsolete: true

Yes, Sam. All the obsolete attachments are abandoned.

Flags: needinfo?(nguyenvandung02051999)
Blocks: 1576130
Assignee: nguyenvandung02051999 → nobody

Hey! This bug was set aside for GSoC but I guess wasn't completed. Is it open for contributions?

Flags: needinfo?(sfoster)

(In reply to Mohd Umar Alam [:umaralam48] from comment #33)

Hey! This bug was set aside for GSoC but I guess wasn't completed. Is it open for contributions?

Yes. The first step is to define a new "browser.tabs.tabmanager.enabled" preference and make the necessary changes to retain the overflow menu so it is always visible (thus making it a tab manager menu rather than a overflow menu). And add a basic test to verify this works. Later bugs will cover the changes to the menu's contents.

Flags: needinfo?(sfoster)

Hi Sam. I am Aditya Sharma. Could you please guide me on how to get started with this bug and make my first contributions to this project.

Could you please provide the relevant repository link where this project is hosted?

(In reply to Aditya Sharma from comment #36)

Could you please provide the relevant repository link where this project is hosted?

This is not good bug to get started contributing to firefox, I suggest picking something from the list at https://codetribute.mozilla.org/projects/ff?tag%3Dgood-first-bug, and following the instructions at https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction

Hi Sam, Can I work on this issue?

I wanted to work on this during GSOC but didn't got selected. So I would like to work on this bug now.

Added a preference to control the visibility of Tab Manager Menu to facilitate the incremental development.

Assignee: nobody → umaralam48

(In reply to Sahil Bhosale from comment #39)

I wanted to work on this during GSOC but didn't got selected. So I would like to work on this bug now.

Hi Sahil, I'm glad to see you back. :umaralam48 is actively working on this one at the moment.

Attachment #9073575 - Attachment is obsolete: true

:amylee, can you clarify what this should look like where there is only a single tab open and the tab strip is not overflowed? In that case the "+" new tab button hugs the trailing edge of the tabs.

Flags: needinfo?(amlee)

(In reply to Sam Foster [:sfoster] (he/him) from comment #42)

:amylee, can you clarify what this should look like where there is only a single tab open and the tab strip is not overflowed? In that case the "+" new tab button hugs the trailing edge of the tabs.

Hi Sam,

The overflow menu should be permanently anchored to the far right of the tab bar (where it currently is now). Thanks

Flags: needinfo?(amlee)
Attachment #9111489 - Attachment description: Bug 1480542: WIP - Added browser.tabs.tabmanager.enabled preference → Bug 1480542: Add browser.tabs.tabmanager.enabled preference

:dao, will you be able to review Attachment #9111489 [details], or can you suggest another reviewer?

Flags: needinfo?(dao+bmo)

(In reply to Sam Foster [:sfoster] (he/him) from comment #45)

:dao, will you be able to review Attachment #9111489 [details], or can you suggest another reviewer?

Done, sorry for the delay.

Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8b0ac5b78b2b
Add browser.tabs.tabmanager.enabled preference r=sfoster,dao
Blocks: 1605071

https://hg.mozilla.org/mozilla-central/rev/8b0ac5b78b2b

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox73: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 73
No longer blocks: 1605071

The context menu for tab manager is left to be implemented. Should a new bug be filed for that?

Status: RESOLVED → VERIFIED
Flags: needinfo?(sfoster)

(In reply to Mohd Umar Alam [:umaralam48] from comment #49)

The context menu for tab manager is left to be implemented. Should a new bug be filed for that?

I think that would be bug 356980?

No longer depends on: 1466732, 1556500
Summary: Implement new overflow menu to permanently be visible → Make tab overflow menu permanently visible behind browser.tabs.tabmanager.enabled preference
No longer blocks: 1576130

(In reply to Dão Gottwald [::dao] from comment #50)

(In reply to Mohd Umar Alam [:umaralam48] from comment #49)

The context menu for tab manager is left to be implemented. Should a new bug be filed for that?

I think that would be bug 356980?

It is. Thanks!

There is a tree of bugs to implement the whole tab manager spec. Some remain to be filed. If you see something in the spec that doesnt appear to have a bug filed for it, feel free to do so.

Flags: needinfo?(sfoster)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: