add aarch64 windows support to moz.configure

RESOLVED FIXED in Firefox 63

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: froydnj, Assigned: froydnj)

Tracking

(Blocks 1 bug)

Trunk
mozilla63
ARM64
Windows
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

11 months ago
I have a surprisingly small set of patches that enables this, assuming you have some other environment variables and things set up correctly.
Assignee

Comment 1

11 months ago
MSVC doesn't define __aarch64__, but uses its own symbol instead.
Attachment #8997248 - Flags: review?(core-build-config-reviews)
Assignee

Comment 2

11 months ago
There is likely more than this, but this is a start.
Attachment #8997249 - Flags: review?(core-build-config-reviews)
Assignee

Comment 3

11 months ago
We need to add mappings for target.cpu to MSVC's arm64 name for
determining various paths, and we need to add an extra case to
get_vc_paths so the compiler can find all the necessary DLLs.
Attachment #8997250 - Flags: review?(core-build-config-reviews)
Attachment #8997248 - Flags: review?(core-build-config-reviews) → review+
Attachment #8997249 - Flags: review?(core-build-config-reviews) → review+
Attachment #8997250 - Flags: review?(core-build-config-reviews) → review+

Comment 4

11 months ago
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbeee9501bd
part 1 - add Windows-specific aarch64 macro detection; r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/d87760979a3e
part 2 - add a case for aarch64* when setting MIDL_FLAGS; r=glandium
https://hg.mozilla.org/integration/mozilla-inbound/rev/c6d07c3eec16
part 3 - add mappings for aarch64 in Windows configure paths; r=glandium

Comment 5

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4dbeee9501bd
https://hg.mozilla.org/mozilla-central/rev/d87760979a3e
https://hg.mozilla.org/mozilla-central/rev/c6d07c3eec16
Status: NEW → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.