Closed
Bug 1480553
Opened 5 years ago
Closed 5 years ago
add aarch64 windows support to moz.configure
Categories
(Firefox Build System :: General, enhancement)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
|
1.02 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
800 bytes,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
|
2.86 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I have a surprisingly small set of patches that enables this, assuming you have some other environment variables and things set up correctly.
|
Assignee | |
Comment 1•5 years ago
|
||
MSVC doesn't define __aarch64__, but uses its own symbol instead.
Attachment #8997248 -
Flags: review?(core-build-config-reviews)
|
|
Assignee | |
Comment 2•5 years ago
|
||
There is likely more than this, but this is a start.
Attachment #8997249 -
Flags: review?(core-build-config-reviews)
|
|
Assignee | |
Comment 3•5 years ago
|
||
We need to add mappings for target.cpu to MSVC's arm64 name for determining various paths, and we need to add an extra case to get_vc_paths so the compiler can find all the necessary DLLs.
Attachment #8997250 -
Flags: review?(core-build-config-reviews)
|
||
Updated•5 years ago
|
Attachment #8997248 -
Flags: review?(core-build-config-reviews) → review+
|
|
||
Updated•5 years ago
|
Attachment #8997249 -
Flags: review?(core-build-config-reviews) → review+
|
|
||
Updated•5 years ago
|
Attachment #8997250 -
Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4dbeee9501bd part 1 - add Windows-specific aarch64 macro detection; r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/d87760979a3e part 2 - add a case for aarch64* when setting MIDL_FLAGS; r=glandium https://hg.mozilla.org/integration/mozilla-inbound/rev/c6d07c3eec16 part 3 - add mappings for aarch64 in Windows configure paths; r=glandium
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/4dbeee9501bd https://hg.mozilla.org/mozilla-central/rev/d87760979a3e https://hg.mozilla.org/mozilla-central/rev/c6d07c3eec16
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•