Closed
Bug 1480590
Opened 6 years ago
Closed 6 years ago
nspr's moz.build file thinks windows only runs on x86ish platforms
Categories
(Firefox Build System :: General, defect)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
|
1.12 KB,
patch
|
chmanchester
:
review+
|
Details | Diff | Splinter Review |
...which results in some hilarious error messages when you try to build for non-x86-ish windows platforms.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8997244 -
Flags: review?(core-build-config-reviews)
|
||
Updated•6 years ago
|
Attachment #8997244 -
Flags: review?(core-build-config-reviews) → review+
|
|
Assignee | |
Comment 2•6 years ago
|
||
I know a little more now than when I wrote this patch, and I think we want an explicit case/define for aarch64, ala bug 1481505.
Attachment #8998306 -
Flags: review?(cmanchester)
|
|
Assignee | |
Updated•6 years ago
|
Attachment #8997244 -
Attachment is obsolete: true
|
|
||
Updated•6 years ago
|
Attachment #8998306 -
Flags: review?(cmanchester) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2498e115c388 add support for aarch64 when setting up NSPR on Windows; r=chmanchester
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/2498e115c388
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
|
||
Updated•6 years ago
|
Assignee: nobody → nfroyd
You need to log in
before you can comment on or make changes to this bug.
Description
•