Closed Bug 1480593 Opened 3 years ago Closed 2 years ago

Allow setting a different instance of perf.html for the new performance panel, using a pref

Categories

(DevTools :: Performance Tools (Profiler/Timeline), enhancement, P1)

Product:
DevTools
Component:
Performance Tools (Profiler/Timeline)
Type:
enhancement

Tracking

(firefox64 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: mstange, Assigned: julienw)

Details

Attachments

(1 file)

Bug 1480593 - Allow setting a different instance of perf.html for the new performance panel, using a pref
46 bytes, text/x-phabricator-request
Details | Review 
At the moment, perf-html.io is hardcoded:

> const tab = browser.addTab("https://perf-html.io/from-addon");

https://searchfox.org/mozilla-central/rev/e52cd92858800a69b74cb97d26d9bdb960d611ca/devtools/client/performance-new/browser.js#31

Can we add a pref for it, so that I can test profiling on Android with a local instance of perf.html?
Priority: -- → P1
I'm taking to make your life easier on this.

Could you work around the issue in some way ?
Assignee: nobody → felash
Yes of course, I'm currently running my local build anyway because I needed to make more changes, so I just changed the string to my local instance of perf.html.
Pushed by jwajsberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c05cdb233b60
Allow setting a different instance of perf.html for the new performance panel, using a pref r=gregtatum
https://hg.mozilla.org/mozilla-central/rev/c05cdb233b60
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in before you can comment on or make changes to this bug.