1480608 - [blob image] Skip over items that aren't in bounds

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement, P3)

Description

[Jeff Muizelaar [:jrmuizel]]

We already have the bounds at hand. It's easy for us to skip over the parts of the blob image that aren't used.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1480608. Skip over items that aren't in DrawTarget/DirtyRect.

Review commit: https://reviewboard.mozilla.org/r/261274/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261274/

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8997585 [details]
Bug 1480608. Skip over items that aren't in DrawTarget/DirtyRect.

https://reviewboard.mozilla.org/r/261274/#review268384

::: gfx/webrender_bindings/Moz2DImageRenderer.cpp:290
(Diff revision 1)
>      int ReadInt() {
>        int ret;

Unrelated to this patch, but should these ints be int32_ts as well?

::: gfx/webrender_bindings/Moz2DImageRenderer.cpp:320
(Diff revision 1)
> -    reader.SkipBounds();
> +    auto combinedBounds = absBounds.Intersect(reader.ReadBounds());
> +    if (combinedBounds.IsEmpty()) {

You're not using the value of combinedBounds, so this could be written as a boolean Intersects check instead.

auto itemBounds = reader.ReadBounds();
if (!absBounds.Intersects(itemBounds)) {
  ...
}

Comment 3

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8997585 [details]
Bug 1480608. Skip over items that aren't in DrawTarget/DirtyRect.

https://reviewboard.mozilla.org/r/261274/#review268804

::: gfx/webrender_bindings/Moz2DImageRenderer.cpp:320
(Diff revision 1)
> -    reader.SkipBounds();
> +    auto combinedBounds = absBounds.Intersect(reader.ReadBounds());
> +    if (combinedBounds.IsEmpty()) {

There's no implementation of Intersects() and it's unclear what the semantics of it should be.

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8997585 [details]
Bug 1480608. Skip over items that aren't in DrawTarget/DirtyRect.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/261274/diff/1-2/

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8997585 [details]
Bug 1480608. Skip over items that aren't in DrawTarget/DirtyRect.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/261274/diff/2-3/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00ff83d23238
Skip over items that aren't in DrawTarget/DirtyRect. r=mstange

Comment 7

[Narcis Beleuzu [:NarcisB]]

Backed out for build bustages on Moz2DImageRenderer.cpp

Push link: https://hg.mozilla.org/integration/autoland/rev/00ff83d23238b770a947bb407ec1afe39c3010b5
Backout link: https://hg.mozilla.org/integration/autoland/rev/24705823c696fbc83b3ace3b0a7f441fa6c2488d
Log link: https://treeherder.mozilla.org/logviewer.html#?job_id=192655253&repo=autoland&lineNumber=21757

Comment 8

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8997585 [details]
Bug 1480608. Skip over items that aren't in DrawTarget/DirtyRect.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/261274/diff/3-4/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6c2a436870e0
Skip over items that aren't in DrawTarget/DirtyRect. r=mstange

Comment 10

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/6c2a436870e0