Closed
Bug 1480628
Opened 5 years ago
Closed 5 years ago
Remove nsIWebShellServices
Categories
(Core :: DOM: Navigation, enhancement, P2)
Core
DOM: Navigation
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: qdot, Assigned: qdot)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
nsIWebShellServices is only implemented by nsDocShell, and only in C++ (via nsIDocShell). We can move the function definitions to the nsIDocShell interface and remove the need for the QI in the HTML parser.
|
Assignee | |
Comment 1•5 years ago
|
||
nsIWebShellServices is only implemented by nsDocShell, and only used in one place in C++. Move definitions to nsIDocShell, and rename functions to show they are only used as part of Charset changes. MozReview-Commit-ID: DOSeE3Doc51
|
|
Assignee | |
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=25c84adad67e31dcbd747615aa043a958d779232
|
||
Updated•5 years ago
|
Priority: -- → P2
|
||
Comment 3•5 years ago
|
||
Comment on attachment 8997229 [details] Bug 1480628 - Remove nsIWebShellServices; r=nika :Nika Layzell has approved the revision. https://phabricator.services.mozilla.com/D2692
Attachment #8997229 -
Flags: review+
Pushed by kmachulis@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/c629114f55f0 Remove nsIWebShellServices; r=nika
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/c629114f55f0
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•