1480638 - Inspect Element is not reported into panel enter/exit events

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[:Harald Kirschner :digitarald]

When toolbox is already open with a panel other than inspector:
  Set `reason` for exit event for current panel to "inspect_dom"

Set `start_state` for inspector enter event  to "inspect_dom"


The property is already in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#478 but doesn't seem to work.

This is important as element inspection is one of the main interactions in DevTools.

Comment 1

[:Harald Kirschner :digitarald]

Could you take a look or would somebody from the Inspector team more suitable?

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I'm on the inspector team now so I will take a look.

Comment 3

[:Harald Kirschner :digitarald]

Mike, will this be ready for 63?

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR

1. Open a panel other than inspector e.g. the performance panel.
2. Right-click -> Inspect element.
3. Close the toolbox.

Issues

- The performance panel's exit event is:
    "reason": "toolbox_show"

  It should be:
    "reason": "inspect_dom"

- The inspectors enter event is:
    "start_state": "toolbox_show"

  It should be:
    "start_state": "inspect_dom"

----------

STR2

1. Open a panel other than inspector e.g. the performance panel.
2. Click the Inspect element icon.
3. Close the toolbox.

Issues

- The performance panel's exit event is:
    "reason": "unknown"

  It should be:
    "reason": "inspect_dom"

- The inspectors enter event is:
    "start_state": "unknown"

  It should be:
    "start_state": "inspect_dom"

Comment 5

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

STR3

1. Open google.com.
2. Open the web console.
3. Type `document.querySelector("img")`.
4. Click the inspect icon displayed in the web console to the right of the image node.
5. Close the toolbox.

Issues

- The performance panel's exit event is:
    "reason": "unknown"

  It should be:
    "reason": "inspect_dom"

- The inspectors enter event is:
    "start_state": "unknown"

  It should be:
    "start_state": "inspect_dom"

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe

Send `inspect_dom` properties from appropriate places.

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=017007a7b4b25e7720287d8b01bc8f824146ed7a

Comment 8

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9001611 [details]
Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbd335b0912a67241bb76dacabd74cfc7083421b

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9001611 [details]
Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe

clearing review flag since it is done in phabricator already

Comment 11

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb5e3e41ad9c466d37f7424d30d3af5d6dc0e115

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/32e98ec84de3
Inspect Element is not reported into panel enter/exit events r=nchevobbe

Comment 13

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/32e98ec84de3