Closed
Bug 1480638
Opened 6 years ago
Closed 6 years ago
Inspect Element is not reported into panel enter/exit events
Categories
(DevTools :: Inspector, defect, P2)
DevTools
Inspector
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: Harald, Assigned: miker)
References
Details
Attachments
(1 file)
When toolbox is already open with a panel other than inspector: Set `reason` for exit event for current panel to "inspect_dom" Set `start_state` for inspector enter event to "inspect_dom" The property is already in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#478 but doesn't seem to work. This is important as element inspection is one of the main interactions in DevTools.
Reporter | ||
Comment 1•6 years ago
|
||
Could you take a look or would somebody from the Inspector team more suitable?
Flags: needinfo?(mratcliffe)
Assignee | ||
Comment 2•6 years ago
|
||
I'm on the inspector team now so I will take a look.
Flags: needinfo?(mratcliffe)
Reporter | ||
Updated•6 years ago
|
Priority: -- → P2
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → mratcliffe
Flags: needinfo?(mratcliffe)
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 4•6 years ago
|
||
str |
STR 1. Open a panel other than inspector e.g. the performance panel. 2. Right-click -> Inspect element. 3. Close the toolbox. Issues - The performance panel's exit event is: "reason": "toolbox_show" It should be: "reason": "inspect_dom" - The inspectors enter event is: "start_state": "toolbox_show" It should be: "start_state": "inspect_dom" ---------- STR2 1. Open a panel other than inspector e.g. the performance panel. 2. Click the Inspect element icon. 3. Close the toolbox. Issues - The performance panel's exit event is: "reason": "unknown" It should be: "reason": "inspect_dom" - The inspectors enter event is: "start_state": "unknown" It should be: "start_state": "inspect_dom"
Assignee | ||
Comment 5•6 years ago
|
||
str |
STR3 1. Open google.com. 2. Open the web console. 3. Type `document.querySelector("img")`. 4. Click the inspect icon displayed in the web console to the right of the image node. 5. Close the toolbox. Issues - The performance panel's exit event is: "reason": "unknown" It should be: "reason": "inspect_dom" - The inspectors enter event is: "start_state": "unknown" It should be: "start_state": "inspect_dom"
Assignee | ||
Comment 6•6 years ago
|
||
Send `inspect_dom` properties from appropriate places.
Assignee | ||
Updated•6 years ago
|
Attachment #9001611 -
Flags: review+
Assignee | ||
Updated•6 years ago
|
Attachment #9001611 -
Flags: review+ → review?(nchevobbe)
Assignee | ||
Comment 7•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=017007a7b4b25e7720287d8b01bc8f824146ed7a
Comment 8•6 years ago
|
||
Comment on attachment 9001611 [details] Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #9001611 -
Flags: review+
Assignee | ||
Comment 9•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dbd335b0912a67241bb76dacabd74cfc7083421b
Comment 10•6 years ago
|
||
Comment on attachment 9001611 [details] Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe clearing review flag since it is done in phabricator already
Attachment #9001611 -
Flags: review?(nchevobbe)
Assignee | ||
Comment 11•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=eb5e3e41ad9c466d37f7424d30d3af5d6dc0e115
Comment 12•6 years ago
|
||
Pushed by mratcliffe@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/32e98ec84de3 Inspect Element is not reported into panel enter/exit events r=nchevobbe
Comment 13•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/32e98ec84de3
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•