Closed Bug 1480638 Opened Last year Closed Last year

Inspect Element is not reported into panel enter/exit events

Categories

(DevTools :: Inspector, defect, P2)

defect

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: Harald, Assigned: miker)

References

Details

Attachments

(1 file)

When toolbox is already open with a panel other than inspector:
  Set `reason` for exit event for current panel to "inspect_dom"

Set `start_state` for inspector enter event  to "inspect_dom"


The property is already in https://dxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/Events.yaml#478 but doesn't seem to work.

This is important as element inspection is one of the main interactions in DevTools.
Could you take a look or would somebody from the Inspector team more suitable?
Flags: needinfo?(mratcliffe)
I'm on the inspector team now so I will take a look.
Flags: needinfo?(mratcliffe)
Priority: -- → P2
Mike, will this be ready for 63?
Flags: needinfo?(mratcliffe)
Assignee: nobody → mratcliffe
Flags: needinfo?(mratcliffe)
Status: NEW → ASSIGNED
STR

1. Open a panel other than inspector e.g. the performance panel.
2. Right-click -> Inspect element.
3. Close the toolbox.

Issues

- The performance panel's exit event is:
    "reason": "toolbox_show"

  It should be:
    "reason": "inspect_dom"

- The inspectors enter event is:
    "start_state": "toolbox_show"

  It should be:
    "start_state": "inspect_dom"

----------

STR2

1. Open a panel other than inspector e.g. the performance panel.
2. Click the Inspect element icon.
3. Close the toolbox.

Issues

- The performance panel's exit event is:
    "reason": "unknown"

  It should be:
    "reason": "inspect_dom"

- The inspectors enter event is:
    "start_state": "unknown"

  It should be:
    "start_state": "inspect_dom"
STR3

1. Open google.com.
2. Open the web console.
3. Type `document.querySelector("img")`.
4. Click the inspect icon displayed in the web console to the right of the image node.
5. Close the toolbox.

Issues

- The performance panel's exit event is:
    "reason": "unknown"

  It should be:
    "reason": "inspect_dom"

- The inspectors enter event is:
    "start_state": "unknown"

  It should be:
    "start_state": "inspect_dom"
Attachment #9001611 - Flags: review+ → review?(nchevobbe)
Comment on attachment 9001611 [details]
Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #9001611 - Flags: review+
Comment on attachment 9001611 [details]
Bug 1480638 - Inspect Element is not reported into panel enter/exit events r?nchevobbe

clearing review flag since it is done in phabricator already
Attachment #9001611 - Flags: review?(nchevobbe)
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/32e98ec84de3
Inspect Element is not reported into panel enter/exit events r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/32e98ec84de3
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.