Closed
Bug 1480650
Opened 6 years ago
Closed 6 years ago
Remove mozilla::HashTable::Stats
Categories
(Core :: MFBT, enhancement)
Core
MFBT
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
|
9.06 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
I bet nobody has used them in years. The use of ad hoc profiling (printfs plus post-processing with a tool like https://github.com/nnethercote/counts) is generally a better approach. Bug 1179657 did likewise for PLDHashTable.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #8997256 -
Flags: review?(luke)
|
|
||
Comment 2•6 years ago
|
||
Comment on attachment 8997256 [details] [diff] [review] Remove mozilla::HashTable::Stats Review of attachment 8997256 [details] [diff] [review]: ----------------------------------------------------------------- Haha, agreed.
Attachment #8997256 -
Flags: review?(luke) → review+
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/91b59c5ea423 Remove mozilla::HashTable::Stats. r=luke
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/91b59c5ea423
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•