1480654 - libmozavutil.so: terminate called after throwing an instance of 'std::runtime_error'

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: nbeleuzu [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=191752227&repo=autoland

https://queue.taskcluster.net/v1/task/EQZCnUBWTOe3TTNxjSSOlw/runs/0/artifacts/public/logs/live_backing.log

[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package> ../../dist/firefox/liblgpllibs.so: No gain. Skipping
[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package> ../../dist/firefox/libmozavutil.so: terminate called after throwing an instance of 'std::runtime_error'
[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package>   what():  malformed .eh_frame
[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package> Traceback (most recent call last):
[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.py", line 339, in <module>
[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package>     main()
[task 2018-08-03T01:52:33.967Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.py", line 333, in main
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>     copier.copy(args.destination)
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/copier.py", line 431, in copy
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>     copy_results.append((destfile, f.copy(destfile, skip_if_older)))
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/files.py", line 296, in copy
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>     elfhack(dest)
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/executables.py", line 124, in elfhack
[task 2018-08-03T01:52:33.968Z] 01:52:33     INFO -  package>     errors.fatal('Error executing ' + ' '.join(cmd))
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/errors.py", line 103, in fatal
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package>     self._handle(self.FATAL, msg)
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package>   File "/builds/worker/workspace/build/src/python/mozbuild/mozpack/errors.py", line 98, in _handle
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package>     raise ErrorMessage(msg)
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package> mozpack.errors.ErrorMessage: Error: Error executing /builds/worker/workspace/build/src/obj-firefox/build/unix/elfhack/elfhack ../../dist/firefox/libmozavutil.so
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:22: recipe for target 'stage-package' failed
[task 2018-08-03T01:52:33.969Z] 01:52:33     INFO -  package> make[5]: *** [stage-package] Error 1
[task 2018-08-03T01:52:33.970Z] 01:52:33     INFO -  package> make[5]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/browser/installer'
[task 2018-08-03T01:52:33.970Z] 01:52:33     INFO -  package> /builds/worker/workspace/build/src/toolkit/mozapps/installer/packager.mk:88: recipe for target 'make-package' failed
[task 2018-08-03T01:52:33.970Z] 01:52:33     INFO -  package> make[4]: *** [make-package] Error 2
[task 2018-08-03T01:52:33.970Z] 01:52:33     INFO -  package> /builds/worker/workspace/build/src/config/rules.mk:423: recipe for target 'default' failed
[task 2018-08-03T01:52:33.970Z] 01:52:33     INFO -  package> make[3]: *** [default] Error 2
[task 2018-08-03T01:52:33.970Z] 01:52:33     INFO -  package> /builds/worker/workspace/build/src/browser/build.mk:6: recipe for target 'package' failed
[task 2018-08-03T01:52:33.971Z] 01:52:33     INFO -  package> make[2]: *** [package] Error 2
[task 2018-08-03T01:52:33.971Z] 01:52:33     INFO -  /builds/worker/workspace/build/src/build/moz-automation.mk:89: recipe for target 'automation/package' failed
[task 2018-08-03T01:52:33.971Z] 01:52:33     INFO -  make[1]: *** [automation/package] Error 2
[task 2018-08-03T01:52:33.971Z] 01:52:33     INFO -  make[1]: *** Waiting for unfinished jobs....

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1480654 - Allow empty eh_frame entries.

Somehow, when building with LTO, clang can end up creating a eh_frame
section with only one, empty, entry (which just looks like a 4-bytes
long section full of 0x00).

Review commit: https://reviewboard.mozilla.org/r/261130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/261130/

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8997260 [details]
Bug 1480654 - Allow empty eh_frame entries.

https://reviewboard.mozilla.org/r/261130/#review268222

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d2eea4c02840
Allow empty eh_frame entries. r=froydnj

Comment 4

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/d2eea4c02840

Comment 5

[Intermittent Failures Robot]

46 failures in 472 pushes (0.097 failures/push) were associated with this bug yesterday.

Repository breakdown:
* mozilla-inbound: 29
* autoland: 17

Platform breakdown:
* linux64: 33
* windows2012-64: 1
* android-4-2-x86: 11
* windows2012-32: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1480654&startday=2018-08-03&endday=2018-08-03&tree=all