Closed Bug 1480663 Opened Last year Closed Last year

Make EditorBase::IsModifiableNode() non-virtual

Categories

(Core :: Editor, enhancement)

x86_64
Windows 8.1
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

Details

Attachments

(1 file)

HTMLEditor::IsModifiableNode() is enough simple and can be checked in EditorBase. So, we should make it non-virtual and check if instance is HTMLEditor in EditorBase::IsModifiableNode().
HTMLEditor::IsModifiableNode() is enough simple and can be checked in
EditorBase. So, we should make it non-virtual and check if instance is
HTMLEditor in EditorBase::IsModifiableNode().
Comment on attachment 8997356 [details]
Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual

Makoto Kato [:m_kato] has approved the revision.

https://phabricator.services.mozilla.com/D2706
Attachment #8997356 - Flags: review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/7ae524e2f774
Make EditorBase::IsModifiableNode() non-virtual r=m_kato
https://hg.mozilla.org/mozilla-central/rev/7ae524e2f774
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.