Closed
Bug 1480663
Opened 6 years ago
Closed 6 years ago
Make EditorBase::IsModifiableNode() non-virtual
Categories
(Core :: DOM: Editor, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
Details
Attachments
(1 file)
HTMLEditor::IsModifiableNode() is enough simple and can be checked in EditorBase. So, we should make it non-virtual and check if instance is HTMLEditor in EditorBase::IsModifiableNode().
|
Assignee | |
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a1c0ff5318c74d895ede64af8e78c936c3d6ca38
|
|
Assignee | |
Comment 2•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d8a56ab7612834eb49fa04bf5e75826b3b346575
|
|
Assignee | |
Comment 3•6 years ago
|
||
HTMLEditor::IsModifiableNode() is enough simple and can be checked in EditorBase. So, we should make it non-virtual and check if instance is HTMLEditor in EditorBase::IsModifiableNode().
|
||
Comment 4•6 years ago
|
||
Comment on attachment 8997356 [details] Bug 1480663 - Make EditorBase::IsModifiableNode() non-virtual Makoto Kato [:m_kato] has approved the revision. https://phabricator.services.mozilla.com/D2706
Attachment #8997356 -
Flags: review+
Pushed by masayuki@d-toybox.com: https://hg.mozilla.org/integration/autoland/rev/7ae524e2f774 Make EditorBase::IsModifiableNode() non-virtual r=m_kato
|
||
Comment 6•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7ae524e2f774
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•