1480676 - Intermittent LeakSanitizer | leak at Realloc, nsTArray_base, AppendElement, mozilla::dom::ChromeUtils::GenerateQI

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect, P5)

Description

[Treeherder Bug Filer]

Filed by: ncsoregi [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=191731517&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/R5_MFFdLR0Kerw2mPUnnog/runs/0/artifacts/public/logs/live_backing.log

https://hg.mozilla.org/mozilla-central/raw-file/tip/layout/tools/reftest/reftest-analyzer.xhtml#logurl=https://queue.taskcluster.net/v1/task/R5_MFFdLR0Kerw2mPUnnog/runs/0/artifacts/public/logs/live_backing.log&only_show_unexpected=1&only_show_unexpected=1

[task 2018-08-02T23:22:30.459Z] 23:22:30     INFO - ERROR | LeakSanitizer | SUMMARY: AddressSanitizer: 448547 byte(s) leaked in 6116 allocation(s).
[task 2018-08-02T23:22:30.459Z] 23:22:30     INFO - LeakSanitizer | To show the addresses of leaked objects add report_objects=1 to LSAN_OPTIONS
[task 2018-08-02T23:22:30.459Z] 23:22:30     INFO - This can be done in testing/mozbase/mozrunner/mozrunner/utils.py
[task 2018-08-02T23:22:30.460Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_calloc, js_pod_arena_calloc, maybe_pod_calloc, AllocScriptData
[task 2018-08-02T23:22:30.460Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_arena_calloc matched a expected leak
[task 2018-08-02T23:22:30.460Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_realloc, js_pod_realloc, maybe_pod_realloc, js::Nursery::reallocateBuffer
[task 2018-08-02T23:22:30.460Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_pod_realloc matched a expected leak
[task 2018-08-02T23:22:30.461Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, js::detail::OrderedHashTable
[task 2018-08-02T23:22:30.461Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_pod_malloc matched a expected leak
[task 2018-08-02T23:22:30.461Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at Realloc, nsTArray_base, AppendElement, mozilla::dom::ChromeUtils::GenerateQI
[task 2018-08-02T23:22:30.462Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at AllocateProtoAndIfaceCache, mozilla::dom::CreateGlobal, mozilla::dom::Window_Binding::Wrap, nsGlobalWindowOuter::SetNewDocument
[task 2018-08-02T23:22:30.462Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_pod_arena_calloc, maybe_pod_calloc, js::ShapeTable::change, grow
[task 2018-08-02T23:22:30.462Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_pod_arena_calloc matched a expected leak
[task 2018-08-02T23:22:30.462Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_calloc, js_pod_arena_calloc, maybe_pod_calloc, pod_calloc
[task 2018-08-02T23:22:30.463Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_arena_calloc matched a expected leak
[task 2018-08-02T23:22:30.463Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at alloc_system::platform::_$LT$impl$u20$core..alloc..GlobalAlloc$u20$for$u20$alloc_system..System$GT$::realloc::h5ee0f446182ccd72, __rdl_realloc, alloc::alloc::realloc::hdec629908d3c3126, _$LT$alloc..alloc..Global$u20$as$u20$core..alloc..Alloc$GT$::realloc::h718cdb88a43fcd0a
[task 2018-08-02T23:22:30.463Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::MozQueryInterface_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle
[task 2018-08-02T23:22:30.464Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at Alloc, nsTSubstring, nsTSubstring, nsTSubstring
[task 2018-08-02T23:22:30.464Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::dom::ChromeUtils::GenerateQI, mozilla::dom::ChromeUtils_Binding::generateQI, CallJSNative, js::InternalCallOrConstruct
[task 2018-08-02T23:22:30.464Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_malloc, js::irregexp::BoyerMooreLookahead::EmitSkipInstructions, js::irregexp::ChoiceNode::Emit, js::irregexp::RegExpCompiler::Assemble
[task 2018-08-02T23:22:30.464Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_arena_malloc matched a expected leak
[task 2018-08-02T23:22:30.465Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at EntrySlotOrCreate, EntrySlotOrCreate, mozilla::dom::URLSearchParams_Binding::CreateInterfaceObjects, mozilla::dom::GetPerInterfaceObjectHandle
[task 2018-08-02T23:22:30.465Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_malloc, js_new, MakeUnique, HashChildren
[task 2018-08-02T23:22:30.465Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_arena_malloc matched a expected leak
[task 2018-08-02T23:22:30.465Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, pod_malloc
[task 2018-08-02T23:22:30.466Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_pod_malloc matched a expected leak
[task 2018-08-02T23:22:30.466Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at mozilla::dom::Performance::CreateForMainThread, nsPIDOMWindowInner::CreatePerformanceObjectIfNeeded, nsPIDOMWindowInner::GetPerformance, mozilla::dom::Window_Binding::get_performance
[task 2018-08-02T23:22:30.466Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, tryNewTenuredObject
[task 2018-08-02T23:22:30.467Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_pod_malloc matched a expected leak
[task 2018-08-02T23:22:30.467Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_malloc, js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc
[task 2018-08-02T23:22:30.467Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_arena_malloc matched a expected leak
[task 2018-08-02T23:22:30.467Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_arena_calloc, js_pod_arena_calloc, maybe_pod_calloc, js::ShapeTable::init
[task 2018-08-02T23:22:30.467Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_arena_calloc matched a expected leak
[task 2018-08-02T23:22:30.468Z] 23:22:30     INFO - TEST-FAIL | LeakSanitizer | leak at js_pod_arena_malloc, js_pod_malloc, maybe_pod_malloc, createTable
[task 2018-08-02T23:22:30.468Z] 23:22:30     INFO - INFO | LeakSanitizer | Frame js_pod_malloc matched a expected leak
[task 2018-08-02T23:22:30.468Z] 23:22:30     INFO - TEST-UNEXPECTED-FAIL | LeakSanitizer | leak at alloc_system::platform::_$LT$impl$u20$core..alloc..GlobalAlloc$u20$for$u20$alloc_system..System$GT$::alloc::h58fa2dc00b294f01, __rdl_alloc, alloc::alloc::alloc::hf84af30e77aa164c, _$LT$alloc..alloc..Global$u20$as$u20$core..alloc..Alloc$GT$::alloc::ha12d59b55529fe17
[task 2018-08-02T23:22:30.469Z] 23:22:30  WARNING - u'runner_teardown': ()

Comment 1

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup

Comment 2

[Cosmin Sabou [:CosminS]]

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=221195251&repo=autoland&lineNumber=66749

Comment 3

[Intermittent Failures Robot]

15 failures in 432 pushes (0.035 failures/push) were associated with this bug yesterday.

Repository breakdown:

• mozilla-central: 4
• try: 1
• mozilla-inbound: 3
• autoland: 7

Platform breakdown:

• linux64: 15

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1480676&startday=2019-01-11&endday=2019-01-11&tree=all

Comment 4

[Andreea Pavel [:apavel]]

Recent occurrences seem to have started from here: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=linux%2Cx64%2Casan%2Cweb%2Cplatform%2Ctests%2Cwith%2Ce10s%2Ctest-linux64-asan%2Fopt-web-platform-tests-reftests-e10s-3%2Cw-e10s%28wr3%29&tochange=49be7aaa199c0be85ec2667c650d4627cfec84c1&fromchange=ff2df6d75dd4ed98f6b29cb84f447c5abba63b68&selectedJob=221668854&group_state=expanded

Andrew can you take a look?

Comment 5

[Andrew McCreight [:mccr8]]

Yeah, I removed the whitelists, but it looks like this leak is happening frequently enough we still need it. I'll add it back.

Comment 6

[Andreea Pavel [:apavel]]

That was fast. Thanks Andrew!

Comment 7

[Intermittent Failures Robot]

26 failures in 2627 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 12
• mozilla-inbound: 5
• try: 2
• mozilla-central: 7

Platform breakdown:

• linux64: 26

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1480676&startday=2019-01-07&endday=2019-01-13&tree=all

Comment 8

[Andrew McCreight [:mccr8]]

I have a patch up for review to revert the whitelisting. In the 10 logs I looked at, the leaks were happening in a single directory. I'll also file a bug to fix the leak. Hopefully this is happening frequently enough that I can reproduce it locally.

Comment 9

[Intermittent Failures Robot]

11 failures in 2378 pushes (0.005 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 5
• mozilla-inbound: 4
• mozilla-central: 2

Platform breakdown:

• linux64: 11

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1480676&startday=2019-01-14&endday=2019-01-20&tree=all

Comment 10

[Andrew McCreight [:mccr8]]

I added back the whitelisting, and then Emilio and Valentin fixed the underlying leaks.