Closed Bug 1480699 Opened 3 years ago Closed 3 years ago

Use IPDL's promise instead of myself in RemoteSpellChecker

Categories

(Core :: Spelling checker, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

References

Details

Attachments

(1 file)

When implementing async call for PRemoteSpellcheckEngine, IPDL doesn't support Promise.  But now, IPDL supports it, so I should convert to it.
When implementing async call for PRemoteSpellcheckEngine, IPDL doesn't support
Promise.  But now, IPDL supports it, so I should convert to it to avoid
unexpected leak.

And SetDictionary supports empty string as parameter to clear dictionary.  So
SetDictionaryFromList should support empty string to clear it to remove
SetDictionary sync call.
Comment on attachment 8997381 [details]
Bug 1480699 - Use IPDL's promise instead in PRemoteSpellcheckEngine. r=masayuki

Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.

https://phabricator.services.mozilla.com/D2714
Attachment #8997381 - Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e771995f99a7
Use IPDL's promise instead in PRemoteSpellcheckEngine. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/e771995f99a7
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Depends on: 1512214
You need to log in before you can comment on or make changes to this bug.