Closed Bug 1480711 Opened 6 years ago Closed 6 years ago

[wpt-sync] Sync PR 12292 - [css-grid] Apply content alignment during second pass

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream]) 

Sync web-platform-tests PR 12292 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12292
Details from upstream follow.

Manuel Rego Casasnovas <rego@igalia.com> wrote:
>  [css-grid] Apply content alignment during second pass
>  
>  When we integrated content alignment in the track sizing algorithm
>  (r566412) we forgot to do it too when the 2nd pass is needed.
>  
>  The patch is very simple and just adds the calls to apply
>  content alignment in LayoutGrid::RepeatTracksSizingIfNeeded()
>  for each axis.
>  
>  The spec also mentions it in the new 3 and 4 steps:
>  https://drafts.csswg.org/css-grid/#algo-overview
>  So the new code just aligns with the spec.
>  
>  BUG=870634
>  TEST=external/wpt/css/css-grid/alignment/grid-content-alignment-second-pass-001.html
>  
>  Change-Id: Iccbcea5da1011eae37b4923bb78334cddc76d027
>  Reviewed-on: https://chromium-review.googlesource.com/1161925
>  WPT-Export-Revision: 51f5bb71f2ede6577ca6286260921f46e22d5782
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests and 8 subtests
OK     : 1
PASS   : 2
FAIL   : 6

New tests that have failures or other problems:
/css/css-grid/alignment/grid-content-alignment-second-pass-001.html
    .grid 3: FAIL
    .grid 4: FAIL
    .grid 5: FAIL
    .grid 6: FAIL
    .grid 7: FAIL
    .grid 8: FAIL
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a2645ddde8ae
[wpt PR 12292] - [css-grid] Apply content alignment during second pass, a=testonly
https://hg.mozilla.org/integration/mozilla-inbound/rev/449629a122f6
[wpt PR 12292] - Update wpt metadata, a=testonly
https://hg.mozilla.org/mozilla-central/rev/a2645ddde8ae
https://hg.mozilla.org/mozilla-central/rev/449629a122f6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.