Closed Bug 1480787 Opened Last year Closed Last year

[wpt-sync] Sync PR 12297 - [LayoutNG] Pass constraint space to inline children for min/max.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 12297 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/12297
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:
>  [LayoutNG] Pass constraint space to inline children for min/max.
>  
>  Orthogonal flow root children are going to need to calculate an
>  extrinsic constraint space. We already got this right for direct block
>  children, but not for floated children of inline child nodes.
>  
>  Three tests start to pass, but I wrote a new test as well, that's more
>  to the point (it used to fail a DCHECK, and then render incorrectly, if
>  we bypassed that).
>  
>  Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
>  Change-Id: Iffea4e8cb26f41f8b5caac4bbb7185df5f62f7d7
>  
>  Reviewed-on: https://chromium-review.googlesource.com/1162175
>  WPT-Export-Revision: 5b0be3b477c000a82d2870327d8b9970b4a1bb47
Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Ran 1 tests
PASS   : 1
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d7eaecb758f7
[wpt PR 12297] - [LayoutNG] Pass constraint space to inline children for min/max., a=testonly
Backed out 16 changesets (bug 1481478, bug 1482434, bug 1477230, bug 1459618, bug 1460281, bug 1450151, bug 1480787, bug 1480724, bug 1459593, bug 1480560) for wpt failures on multipefiles. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=193473321&repo=mozilla-inbound

INFO - TEST-UNEXPECTED-PASS | /svg/painting/reftests/markers-orient-001.svg | expected FAIL
19:42:55     INFO - TEST-INFO expected FAIL | took 252ms
19:42:55     INFO - PID 5788 | 1534016575691	Marionette	INFO	Stopped listening on port 2828
19:42:55     INFO - PID 5788 | [Child 1260, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 1260, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4120, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4120, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Parent 5788, Gecko_IOThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4888, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Child 4888, Chrome_ChildThread] WARNING: pipe error: 109: file z:/build/build/src/ipc/chromium/src/chrome/common/ipc_channel_win.cc, line 346
19:42:55     INFO - PID 5788 | [Parent 5788, Gecko_IOThread] WARNING: file z:/build/build/src/ipc/chromium/src/base/process_util_win.cc, line 188
19:42:56     INFO - Browser exited with return code 0
19:42:56  WARNING - u'runner_teardown': ()
19:42:56     INFO - Setting up ssl
19:42:56     INFO - certutil | 
19:42:56     INFO - certutil | 
19:42:56     INFO - certutil | 
19:42:56     INFO - Certificate Nickname                                         Trust Attributes
19:42:56     INFO -                                                              SSL,S/MIME,JAR/XPI
19:42:56     INFO - 
19:42:56     INFO - web-platform-tests      

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=16c9abfa230cd3fe48e7772022c7a2fe70a314be

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de68b04194643a337a75616de65dbd76979846c2
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/52ddadb5708f
[wpt PR 12297] - [LayoutNG] Pass constraint space to inline children for min/max., a=testonly
https://hg.mozilla.org/mozilla-central/rev/52ddadb5708f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.