Missing RTL support for about:crashes

RESOLVED FIXED in Firefox 63

Status

()

defect
RESOLVED FIXED
9 months ago
a month ago

People

(Reporter: itiel_yn8, Assigned: gandalf)

Tracking

({regression})

unspecified
mozilla63
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62 unaffected, firefox63 fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

9 months ago
Posted image Screenshot
This used to be okay a few days ago.
Didn't confirm it with Mozregression but I think bug 1476034 introduced this issue.

See attached.
Assignee: nobody → adeschamps
Status: NEW → ASSIGNED
(Assignee)

Comment 2

9 months ago
I have a patch that sets the document's directionality in bug 1455649. I'll extract it here

I talked to Alexis on IRC and I'm taking over this bug.
Assignee: adeschamps → gandalf
Component: General → Internationalization
Product: Firefox → Core
(Assignee)

Comment 3

9 months ago
Set document's directionality in Fluent.
Comment on attachment 8997486 [details]
Bug 1480798 - Set document's directionality in Fluent. r?stas

Staś Małolepszy :stas has approved the revision.

https://phabricator.services.mozilla.com/D2732
Attachment #8997486 - Flags: review+

Comment 5

9 months ago
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c0bf622859f6
Set document's directionality in Fluent. r=stas
Backed out changeset c0bf622859f6 (bug 1480798) for chrome failures at intl/l10n/test/dom/test_domloc.xul 

Backout: https://hg.mozilla.org/integration/autoland/rev/f20fddf6df089117e5d56fea72e97d0f33fad1a7

Failure push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=c0bf622859f64edad0f259277758bbbe11bb3cbf&selectedJob=191945058

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=191945058&repo=autoland&lineNumber=1840


[task 2018-08-03T20:32:50.954Z] 20:32:50     INFO -  77 INFO TEST-START | intl/l10n/test/dom/test_domloc.xul
[task 2018-08-03T20:37:48.891Z] 20:37:48     INFO -  78 INFO TEST-UNEXPECTED-FAIL | intl/l10n/test/dom/test_domloc.xul | Test timed out.
[task 2018-08-03T20:37:48.891Z] 20:37:48     INFO -  reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:7
[task 2018-08-03T20:37:48.891Z] 20:37:48     INFO -  TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
Flags: needinfo?(gandalf)

Comment 7

9 months ago
Pushed by zbraniecki@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1748bdd2dcaf
Set document's directionality in Fluent. r=stas
(Assignee)

Comment 8

9 months ago
A minor tweak to a test.
Flags: needinfo?(gandalf)

Comment 9

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1748bdd2dcaf
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
(Reporter)

Comment 10

9 months ago
Some elements are still LTR'd on latest Nightly.
Should I file a new bug for that?
(Reporter)

Comment 11

9 months ago
Posted image LTR elements
(In reply to Itiel from comment #10)
> Some elements are still LTR'd on latest Nightly.
> Should I file a new bug for that?

Yes, please. That seems like some CSS in need of fixing.
(Reporter)

Updated

9 months ago
Depends on: 1481061

Updated

a month ago
Depends on: 1535215
You need to log in before you can comment on or make changes to this bug.