Closed Bug 1480810 Opened 3 years ago Closed 3 years ago
_COMPLEX is an unknown type
We reference PREF_COMPLEX in testing/marionette/prefs.js, but it is now an unknown type.
A warning appears in the console when you run xpcshell tests that the PREF_COMPLEX type is no longer, and we should therefore remove it from Marionette as well.
Attachment #8997466 - Flags: review?(dburns)
Assignee: nobody → ato
Status: NEW → ASSIGNED
Attachment #8997466 - Flags: review?(dburns) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/541bad93631c Drop PREF_COMPLEX from Marionette prefs module. r=automatedtester
So how are complex values handled those days? Please see my comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1432894#c28. Please check that we don't regress something here.
PREF_COMPLEX is not a variant of nsIPrefBranch, which is why we were seeing a browser console warning.
That's not what I was asking. But I checked it myself now, and all the code related to get/set complex preferences was removed by bug 1414096. As such our logic in Marionette for preferences types is fine, and we don't miss that specific case.
You need to log in before you can comment on or make changes to this bug.