1480810 - PREF_COMPLEX is an unknown type

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

We reference PREF_COMPLEX in testing/marionette/prefs.js, but it
is now an unknown type.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: Drop PREF_COMPLEX from Marionette prefs module.

A warning appears in the console when you run xpcshell tests that
the PREF_COMPLEX type is no longer, and we should therefore remove
it from Marionette as well.

Comment 2

[Andreas Tolfsen ❲:ato❳]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d478ff1024c08d820c67dd8eb63626f74f1005d0

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/541bad93631c
Drop PREF_COMPLEX from Marionette prefs module. r=automatedtester

Comment 4

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/541bad93631c

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

So how are complex values handled those days? Please see my comment from https://bugzilla.mozilla.org/show_bug.cgi?id=1432894#c28. Please check that we don't regress something here.

Comment 6

[Andreas Tolfsen ❲:ato❳]

PREF_COMPLEX is not a variant of nsIPrefBranch, which is why we
were seeing a browser console warning.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

That's not what I was asking. But I checked it myself now, and all the code related to get/set complex preferences was removed by bug 1414096. As such our logic in Marionette for preferences types is fine, and we don't miss that specific case.