Closed
Bug 1480841
Opened 4 years ago
Closed 4 years ago
Raptor support for running speedometer on android geckoview
Categories
(Testing :: Raptor, enhancement)
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: rwood, Assigned: rwood)
References
Details
Attachments
(1 file)
No description provided.
Assignee | ||
Comment 1•4 years ago
|
||
Since I'm going on PTO after this week, I'm going to post to phabricator what I have done thus far. Yet to be solved: - getting results from the benchmark back to the webext (Bug 1483600) - add support to shutdown the geckoview_example app on the device (haven't updated the browser shutdown code in control_server.py yet) - on my machine and google pixel 2 the speedometer benchmark runs really slow - however the same benchmark also runs slow on my machine on Firefox desktop, I believe it's a problem with my localhost for some reason; it would be good for someone to try raptor-speedometer on their google p2 though to confirm it runs fast enough - decide on how many pagecycles to run depending on how long it takes; currently just using 1 with an extended timeout Hopefully we can get it all running by the end of the week anyway.
Assignee | ||
Comment 2•4 years ago
|
||
Assignee | ||
Comment 3•4 years ago
|
||
Some notes to help: - make sure the android device is in superuser mode - install the geckoview_example app with -g (i.e. adb install -g ../Downloads/geckoview_example.apk) so that the app permissions are on (or manually turn on the app's storage perm) - you have to uninstall the old geckoview_example app first when you're updating to a newer one (i.e. adb uninstall org.mozilla.geckoview_example) - raptor browser extension console messages do appear in adb logcat via the GeckoConsole - so this is handy: adb logcat | grep GeckoConsole - you can also debug using the Firefox WebIDE, cick on the android device listed under "USB Devices" and then "Main Process" or the 'localhost: Speedometer.." tab process The raptor command line to run speedometer on geckoview is: ./mach raptor-test --test raptor-speedometer --app=geckoview --binary="org.mozilla.geckoview_example"
Assignee | ||
Comment 4•4 years ago
|
||
I've updated the patch on phabricator - added code to shutdown the GeckoView app.
Assignee | ||
Comment 5•4 years ago
|
||
With the fix by the mobile team in Bug 1483600, speedometer is now running on geckoview on my google pixel 2 successfully and reporting results. :) To be decided is how many pagecycles of the benchmark to run (and the timeout) - it is currently set to 1 pagecycle in the test manifest. I tested multiple pagecycles (2) and it worked fine. Seems to run a bit slow on my device but I *believe* it's an issue with my localhost as the speedometer benchmark runs slow for me on Firefox desktop as well.
Comment 6•4 years ago
|
||
keep it at one for now until we get it running in automation- possibly 2 or 3 will be the final number we agree upon.
Assignee | ||
Comment 7•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4e4d9425042ec990be90a83ffa721122129912b
Comment 8•4 years ago
|
||
Comment on attachment 9001401 [details] Bug 1480841 - Raptor support for running speedometer on geckoview Joel Maher ( :jmaher ) (UTC+2) has approved the revision.
Attachment #9001401 -
Flags: review+
Assignee | ||
Comment 9•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b7e1c2b5af75c2106fe1422a26d925062bfd3f61
Assignee | ||
Comment 10•4 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=177285691acacc1d66903cc49a4c80f4894c2108
Assignee | ||
Comment 11•4 years ago
|
||
(In reply to Robert Wood [:rwood] from comment #10) > https://treeherder.mozilla.org/#/jobs?repo=try&revision=177285691acacc1d66903cc49a4c80f4894c2108 Pushed to try to check unit test is fixed, and to ensure didn't break anything - looks good
Assignee | ||
Comment 12•4 years ago
|
||
FYI this is to run raptor speedometer on the geckoview_example app, using a locally connected android device (tested on google pixel 2).
Comment 13•4 years ago
|
||
Pushed by rwood@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/90caf8ba542c Raptor support for running speedometer on geckoview r=jmaher
Comment 14•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/90caf8ba542c
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•